161249 - maximize error when parts of the window are out of sight

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[oliver]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.1b) Gecko/20020722
BuildID:    2002072203

a window that is not completely visible on the screen (e.g. the lower end is out
of the screen) can not be maximized! if you try it the result is an empty
window. even the top bars (locationbar, bookmarkbar) disappears. you have to
make the window smaller so everything is visible again and press the maximize
button again...


Reproducible: Always
Steps to Reproduce:
1.create a new window
2.move some parts of the window out of your monitor (e.g. move down until one
half of the window is not visible anymore)
3.press the green maximize button in the window bar


Actual Results:  the window will not maximize and is completely empty now

Expected Results:  maximize the window?!?

i have two screens, but i think it is not the problem because it happens even on
the main screen...

Comment 1

[R.K.Aa.]

somewhat resemblant of bug 150057

Comment 2

[R.K.Aa.]

and bug 159125

Comment 3

[Adrian Ulrich]

I saw something like this also for the first time today:

Build 20020805 on Linux..

I had mozilla between virtual destkop 1&2 (WM: Enlightenment), when i tried to
resize (not maximize) mozilla, it didn't redraw anything..

Could be a dup of bug 159125 .. i'll have a look at it on OSX soon..

Comment 4

[Greg K.]

WorksForMe using FizzillaCFM/2002080508, although I'm testing on a
single-monitor set-up. Reassigning to XP Apps: GUI Features.

Comment 5

[Greg K.]

Still WorksForMe using FizzillaMach/2003021203. [e-mail], can you still
reproduce this problem using a current nightly build?

Comment 6

[Asa Dotzler [:asa]]

This bug gives the same symptoms as bug 167663 (starting with comment #123) I
suspect the same or similar problem is causing both. 


Steps to reproduce:

1. Launch Mozilla (new profile defaults to not-zoomed state)
2. Zoom/Maximize Mozilla by clicking the green + button in the browser titlebar.
3. Drag the window left about 10 pixels, putting the left edge of the browser
window just offscreen.
4. Click the Zoom/Maximize button.

Result: The toolbars will become white and only buttons which have a hover state
will repaint when you move the mouse pointer over them. 

Expected result: Toolbars should not get invalidated. 

Comment 7

[louis bennett]

this problem also seems to happen if you move your window to the position that
it (by default) maximizes to. specifically:

[1] maximize window
[2] "resize" window and return it to its original (maximized) size (e.g., drag
the window to be smaller, then back it its original position, without letting go
of the mouse button.)
[3] try to maximize the window again. you'll either lose the content pane or the
chrome.

i'm using just one monitor, using moz 1.6 on OS X 10.2.

Comment 8

[chris hofmann]

looks like this has missed 1.7a -- blake can you get this for beta?

Comment 9

[Prognathous]

Unless I'm missing something, a company called GlobalMinds Internet is willing
to pay a bounty of $3500 to fix this bug -
http://mozdev.org/pipermail/project_owners/2004-February/001693.html

Prog.

Comment 10

[Simon Fraser [no longer active]]

Taking bug

Comment 11

[Simon Fraser [no longer active]]

*** Bug 159125 has been marked as a duplicate of this bug. ***

Comment 12

[Simon Fraser [no longer active]]

There were several issues that contributed to this bug.

First, erasing of parts of the window on this 'bad' maximize was caused
by a call to EraseRect() in nsMacMessagePump::DoMouseDown(). This
EraseRect is redundant, but even it had a bug; the clip region was not
reset before the EraseRect call, so it was unpredictable which parts of
the window got clobbered. This is why most people only see toolbars go
blank, but in some situations large portions of the window are blanked
out.

Now to explain why in this particular situation the erased portions were
not redrawn. In nsMacWindow::SetSizeMode(), there was some code that
returned early if the new size mode (i.e. "maximized" or "normal") was
the same as the old size mode. In this early return case, no redrawing
of the window contents happened, so areas of the window remained blank.
Mike Calumus was on the right track with his fix in
http://bugzilla.mozilla.org/show_bug.cgi?id=167663#c130, but he was not
able to explain the details.

I think there are 2 things that need fixing here.

1. We can remove the EraseRect, because we can be sure that the entire
   window contents will be redrawn on resize by the code in
   nsMacWindow::WindowEventHandler(), which calls 
     ::InvalWindowRect(myWind, ::GetWindowPortBounds(myWind, &bounds));

2. We should fix nsMacWindow::SetSizeMode() so that clicking the maximize
   button for a maximized window that is partially offscreen moves that window
   back onscreen, like all other Mac OS X apps.
   
   I've verified that with the short-circuit code removed, we don't do any
   redundant window zooming (the mVisible check takes care of that).

Patch coming.

Comment 13

[Simon Fraser [no longer active]]

Attachment: Remove a redundant EraseRect call on zoom, and fix SetSizeMode to move maximzed windows back onscreen

Comment 14

[Blake Ross]

Comment on attachment 141907 [details] [diff] [review]
Remove a redundant EraseRect call on zoom, and fix SetSizeMode to move maximzed windows back onscreen

Do you still need PRInt32 currentMode?

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

foiled again!

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

Just a side note that came out of my investigation of this bug, Simon, when a
window is maximized and then moved, should the maximized state be reset to "normal"?

Comment 17

[Simon Fraser [no longer active]]

Blake: you're right, I must have missed the 'unused variable' warning.
Ben: you're also right, that seems to be the usual behaviour, though I'm not
sure if our zoom code will want to move the window back partially offscreen.

Comment 18

[Asa Dotzler [:asa]]

Who can review and land this fix?

Comment 19

[Simon Fraser [no longer active]]

Comment on attachment 141907 [details] [diff] [review]
Remove a redundant EraseRect call on zoom, and fix SetSizeMode to move maximzed windows back onscreen

I'll remove the 'currentMode' variable before checkin.

Comment 20

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 141907 [details] [diff] [review]
Remove a redundant EraseRect call on zoom, and fix SetSizeMode to move maximzed windows back onscreen

r=[e-mail]

Comment 21

[chris hofmann]

Comment on attachment 141907 [details] [diff] [review]
Remove a redundant EraseRect call on zoom, and fix SetSizeMode to move maximzed windows back onscreen

a=chofmann for 1.7b

Comment 22

[Simon Fraser [no longer active]]

Checked in:

Checking in nsMacMessagePump.cpp;
/cvsroot/mozilla/widget/src/mac/nsMacMessagePump.cpp,v  <--  nsMacMessagePump.cpp
new revision: 1.141; previous revision: 1.140
done
Checking in nsMacWindow.cpp;
/cvsroot/mozilla/widget/src/mac/nsMacWindow.cpp,v  <--  nsMacWindow.cpp
new revision: 1.141; previous revision: 1.140
done

Thanks guys!