Closed Bug 1612509 Opened 3 years ago Closed 3 years ago

System Highlight colour is not respected for the Urlbar result highlight in Dark theme

Categories

(Firefox :: Address Bar, defect, P3)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 74
Iteration:
74.2 - Jan 20 - Feb 09
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

Attachments

(1 file)

Bug 1612509 - Remove custom colour for autocomplete-popup-highlight-background in Dark Mode. r?dao
47 bytes, text/x-phabricator-request
Details | Review

In default/light mode, we support using the system Highlight colour as the background colour for selected Urlbar results. In Dark Mode it is always blue.

This is intentional from what I remember. Goes back to bug 1453722, I think. However, we only do this when explicitly selecting the dark theme in Firefox, not when using system dark mode. I'd be okay with dropping this behavior.

Points: 2 → 1
Priority: -- → P3
Summary: System Highlight colour is not respected for the Urlbar result highlight in Dark Mode → System Highlight colour is not respected for the Urlbar result highlight in Dark theme
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 74.2 - Jan 20 - Feb 09

I opted to remove this colour altogether instead of adding branching logic for the legacy Urlbar and the search bar. The legacy Urlbar is being replaced and this patch will land in the same version, and the search bar should support system Highlight colours as well.

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e92e3db3bbb4
Remove custom colour for autocomplete-popup-highlight-background in Dark Mode. r=dao

https://hg.mozilla.org/mozilla-central/rev/e92e3db3bbb4

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in before you can comment on or make changes to this bug.