Move all page navigation related code into parent process
Categories
(Remote Protocol :: CDP, task, P3)
Tracking
(Not tracked)
People
(Reporter: whimboo, Unassigned)
References
Details
(Whiteboard: [puppeteer-beta2-mvp])
Before the work on the JSWindowActor API can be started, all the page navigation related code should be moved out of the content processes. That was a clear statement by the Fission team when I was talking with them about Fission during the office hours.
So this affects pure navigation, reload, and back and forward navigation.
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 2•4 years ago
|
||
When working on this bug we have to make sure to add a certain amount of navigation tests before doing the refactoring.
Reporter | ||
Updated•4 years ago
|
For Page.navigate
, for example, calling this.session.browsingContext.loadURI
from the parent Page domain seems to work. Does that fulfill the goal of moving out of the content process? (If yes, then moving navigate
at least is trivial)
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=066f260d2b305bf5685060901a623837cba58e31
Reporter | ||
Comment 4•4 years ago
|
||
No, we still register listeners for all the required events (DOMContentLoaded, load, etc) in the content process. We have to get everything moved into the parent process. Same also applies to history navigation.
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Updated•4 years ago
|
Updated•4 years ago
|
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Reporter | ||
Comment 6•3 years ago
|
||
Our current code around navigation works just fine with Fission enabled. The only issue that we currently have is with COOP involved (bug 1706353).
Reporter | ||
Updated•2 years ago
|
Updated•2 years ago
|
Reporter | ||
Comment 7•4 months ago
|
||
We don't have the time to get this refactoring done. Instead one should use the WebDriver BiDi protocol.
Description
•