Closed Bug 1612538 Opened 4 years ago Closed 4 months ago

Move all page navigation related code into parent process

Categories

(Remote Protocol :: CDP, task, P3)

task

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: whimboo, Unassigned)

References

Details

(Whiteboard: [puppeteer-beta2-mvp])

Before the work on the JSWindowActor API can be started, all the page navigation related code should be moved out of the content processes. That was a clear statement by the Fission team when I was talking with them about Fission during the office hours.

So this affects pure navigation, reload, and back and forward navigation.

Priority: P3 → P2
Whiteboard: [puppeteer-beta-mvp]

When working on this bug we have to make sure to add a certain amount of navigation tests before doing the refactoring.

See Also: → 1612831
Priority: P2 → P3
Whiteboard: [puppeteer-beta-mvp] → [puppeteer-beta-reserve]

For Page.navigate, for example, calling this.session.browsingContext.loadURI from the parent Page domain seems to work. Does that fulfill the goal of moving out of the content process? (If yes, then moving navigate at least is trivial)

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=066f260d2b305bf5685060901a623837cba58e31

Flags: needinfo?(hskupin)

No, we still register listeners for all the required events (DOMContentLoaded, load, etc) in the content process. We have to get everything moved into the parent process. Same also applies to history navigation.

Flags: needinfo?(hskupin)
Priority: P3 → P2

Tracking for Fission M6b Nightly milestone.

Fission Milestone: --- → M6b
Fission Milestone: M6b → Future
Whiteboard: [puppeteer-beta-reserve] → [puppeteer-beta2-mvp]
No longer blocks: marionette-fission
Component: CDP: Page → CDP

Our current code around navigation works just fine with Fission enabled. The only issue that we currently have is with COOP involved (bug 1706353).

Priority: P2 → P3
Fission Milestone: Future → ---
Severity: normal → S3

We don't have the time to get this refactoring done. Instead one should use the WebDriver BiDi protocol.

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.