1612557 - Add 'Media' category for profiler label

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[Alastor Wu [:alwu]]

Now all media playback functions showed in the profiler stack would be put in Other category. We should add a new category and different sub-category to mark different usage of functions.

Comment 1

[Alastor Wu [:alwu]]

Target it on this release cycle.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1612557 - part1 : create a profiling category `Media`.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1612557 - part2 : create a sub-category 'Cubeb'.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1612557 - part3 : add Graphic label in `ImageContainer::SetCurrentImages()`.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1612557 - part4 : use `Media` category for markers

Comment 6

[Alastor Wu [:alwu]]

Set the flag for Fx77 as well, because I'd like to uplift these patches to Fx77 in order to help us analysis profiled result from Fx77.

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1612557 - part5 : use `MediaSampleMarkerPayload` in VideoSink.

This patch will do :

• use MediaSampleMarkerPayload to replace VideoFrameMarkerPayload

The advantage of doing so :

• after finishing a support for MediaSampleMarkerPayload in profiler front-end side, we can show the sample's start and end time when hovering on the marker icon.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e386f0eca3a
part1 : create a profiling category `Media`. r=bryce,gerald
https://hg.mozilla.org/integration/autoland/rev/495a33ed008a
part2 : create a sub-category 'Cubeb'. r=padenot
https://hg.mozilla.org/integration/autoland/rev/0bd32e4fa068
part3 : add Graphic label in `ImageContainer::SetCurrentImages()`. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/8883a6bee292
part4 : use `Media` category for markers r=bryce,gerald,canaltinova
https://hg.mozilla.org/integration/autoland/rev/cd62b971a4f4
part5 : use `MediaSampleMarkerPayload` in VideoSink. r=jolin

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/6e386f0eca3a
https://hg.mozilla.org/mozilla-central/rev/495a33ed008a
https://hg.mozilla.org/mozilla-central/rev/0bd32e4fa068
https://hg.mozilla.org/mozilla-central/rev/8883a6bee292
https://hg.mozilla.org/mozilla-central/rev/cd62b971a4f4