1612571 - Make getLastMessageId not use Array.from

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

With many messages to handle, getting the last message id as we do (turning a map into an array and getting the last element) takes a very long time and consumes a lot of memory:

https://searchfox.org/mozilla-central/rev/2e355fa82aaa87e8424a9927c8136be184eeb6c7/devtools/client/webconsole/reducers/messages.js#1682-1684

Comment 1

[Florian Quèze [:florian]]

Assuming I understood correctly that the last message id is the id of the last message, could we just store that last message id at the time we add the message?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1612571 - Increase number of logged messages in DAMP bulklog test. r=jdescottes.

Logging a thousand messages instead of 10.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1612571 - Store the last message id instead of computing it from the message map. r=jlast.

The id was retrieved by transforming the map into an array
and getting the last element of it. This was slow and
allocatiing a lot of memory when the messages Map contained
a lot of elements.
This patch make it so we're now storing the last message
id directly in the state so we can get it in a cheaper way.

Depends on D62184

Comment 4

[Phabricator Automation]

Comment on attachment 9125387 [details]
Bug 1612571 - Increase number of logged messages in DAMP bulklog test. r=jdescottes.

Revision D62184 was moved to bug 1614366. Setting attachment 9125387 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f62d325fc393
Store the last message id instead of computing it from the message map. r=jlast.

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f62d325fc393