1612589 - Images memory reporting excluding footprint for many surface types

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P2)

Description

[Andrew Osmond [:aosmond] (he/him)]

Optimized source surfaces may be stored in imagelib's surface cache. These may not implement DataSourceSurface::AddSizeOfExcludingThis. This should be moved to SourceSurface and we should add a new type for "not sure" (may be heap, may not be heap). This can produce very misleading footprint reporting for images on perfherder.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1612589 - Improve image memory reporting even further.

This patch adds reporting the surface types used by the image frame in a
bit mask (such if it is a CAPTURE including a DATA_SHARED, the mask will
be 1 << CAPTURE | 1 << DATA_SHARED), as well as an estimated size
included in the report as decoded-unknown for when we do not know if the
surface is on the heap or the non-heap specifically. This is the default
implementation for a SourceSurface as well, so we should no longer have
the case where surfaces appear empty despite being in the cache. It also
makes requests being validated as always notable for reporting purposes.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Bumping priority due to its utility in debugging the true memory footprint and future images missing issues; the surface types mask would have been instrumental in solving bug 1612207, for example.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2dbb80db855
Improve image memory reporting even further. r=tnikkel

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Please note this bug may cause "memory regressions" because the images reporting simply didn't record certain surfaces. This is not a true regression, just more accurate reporting.

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b2dbb80db855

Comment 6

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #24856 (as of Wed, 05 Feb 2020 17:54:15 GMT) ==

Improvements:

2% Images macosx1014-64-shippable opt tp6 7,794,899.26 -> 7,613,702.64

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24856

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

That is surprising...