1612626 - [wpt-sync] Sync PR 21534 - [TableNG] Fix minor colspan percentage redistribution bug

Status: RESOLVED FIXED

(Core :: Layout: Tables, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21534 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21534
Details from upstream follow.

Aleks Totic <[e-mail]> wrote:

[TableNG] Fix minor colspan percentage redistribution bug

Legacy code was not enforcing 2 invariants of colspan
redistribution.

• min_width \<= max_width
• redistribution should never shrink width.

The fix introduces a part of new colspan redistribution
test suite.

Bug: 958381
Change-Id: I3cc6e55af86dd376ffbc0a4c4710900df8bccce5
Reviewed-on: https://chromium-review.googlesource.com/2030805
WPT-Export-Revision: 6b138bd90a3f005e71c72e35dc8c3212d7054b0d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7923178b27291ea38928005067eda3e08a016874

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 44 tests

Status Summary

Firefox

OK : 1
PASS: 3[GitHub] 46[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 1

Chrome

OK : 1
PASS: 3
FAIL: 1

Safari

OK : 1
PASS: 3
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-tables/width-distribution/colspan_redistribution.tentative.html
table 3: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb31e98a525f
[wpt PR 21534] - [TableNG] Fix minor colspan percentage redistribution bug, a=testonly
https://hg.mozilla.org/integration/autoland/rev/e4433afe00e6
[wpt PR 21534] - Update wpt metadata, a=testonly

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/eb31e98a525f
https://hg.mozilla.org/mozilla-central/rev/e4433afe00e6