Closed Bug 1612735 Opened 2 years ago Closed 2 years ago

font size of permission settings regressed (font is too small)

Categories

(Firefox :: Preferences, defect)

73 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 74
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- unaffected
firefox73 --- wontfix
firefox74 --- fixed

People

(Reporter: soeren.hentzschel, Assigned: bytesized)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

STR:

  1. open Preferences > Privacy & Security
  2. scroll to the permission section
  3. press on of the "Settings…" buttons

The font size of the whole dialog is too small. It's a regression from bug 1585482.

17:56.35 INFO: Narrowed inbound regression window from [1fb1ca98, e183cbb4] (3 builds) to [88b25807, e183cbb4] (2 builds) (~1 steps left)
17:56.35 INFO: No more inbound revisions, bisection finished.
17:56.35 INFO: Last good revision: 88b25807638231dcf403d8f0b597fc770f1d24a4
17:56.35 INFO: First bad revision: e183cbb4983cfb3aecf97ab18fad916b91f89e7e
17:56.35 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=88b25807638231dcf403d8f0b597fc770f1d24a4&tochange=e183cbb4983cfb3aecf97ab18fad916b91f89e7e

Flags: needinfo?(ksteuber)

I performed the STR on a current version of Nightly and again on a pre-Bug 1585482 version of Nightly, and they look identical to me. Could you provide more information on your configuration? I think some of the font sizes are set to be specific to the Operating System. A screenshot might be nice too, if you wouldn't mind.

Flags: needinfo?(ksteuber) → needinfo?(soeren.hentzschel)
Attached image screenshot

I attached a screenshot for comparison.
The operating system is macOS Catalina.

Flags: needinfo?(soeren.hentzschel)
Assignee: nobody → ksteuber
QA Whiteboard: [qa-regression-triage]

(In reply to Kirk Steuber (he/him) [:bytesized] from comment #3)

I have identified that this problem does not just happen on this page. It happens on any preferences dialog that does not actually use the <dialog> element, as a result of this change. Here are a list of dialogs that I believe have the same problem:

I'm looking into possible fixes for this. I haven't yet identified an obvious way of distinguishing, in CSS, the difference between a <window> with and without a <dialog> in it.

Is it possible we could switch that selector back to :root > *?

That seems like a reasonable solution to me. I'll post a patch.

Pushed by ksteuber@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c214336a3b2
Fix font size regression on preferences dialogs without a <dialog> element r=bgrins
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in before you can comment on or make changes to this bug.