1612738 - Minimum window size is too small

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Christian Stadelmann]

Attachment: Screenshot of a very small firefox window

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

1. open a firefox window
2. resize it to be very small

Environment: Fedora 31, GNOME shell on wayland.

Actual results:

Window is very small, to small to even fully display window decorations and the urlbar.

Expected results:

Firefox should enforce a minimum size to make sure that it at least displays the window decorations and the urlbar completely.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

It's because the minimal size also contains CSD decorations - we should add them to minimal window size.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

btw. that needs to be added at nsWindow::LockAspectRatio() or nsWindow::ApplySizeConstraints().

Comment 3

[Mazin AlHaddad]

Can I attempt to fix this? I'd love to give it a go!

Comment 4

[Martin Stránský [:stransky] (ni? me)]

(In reply to Mazin AlHaddad from comment #3)

Can I attempt to fix this? I'd love to give it a go!

Yes please, go ahead!

Comment 5

[Martin Stránský [:stransky] (ni? me)]

I think we need to add CSD size to constraints on wayland.

Comment 6

[Sarvesh Tandon]

If this bug is still open, can I work on this? P. S. this will be my first bug.

Comment 7

[Akshat [:baka]]

Attachment: Alpha.png

Hello, I tried to reproduce this bug on my mozilla and to me minimum window size seems to be optimum. It is creating no problems. I am working on Ubuntu 20.04 and Firefox version 83.0a1 .

Can someone help me if I am missing something. And help me proceed with this bug.

Comment 8

[Mazin AlHaddad]

Hi, sorry everyone! I originally planned to get this done quickly but I got busy with work and basically forgot about it. The bug is still reproducible as long as the DE doesn't enforce a minimum size. I believe this is because we don't set a geometry for the mContainer (it's only set on mShell). I've already written a patch and will hopefully have it tested by tomorrow (setting up the environment again).

Comment 9

[Mazin AlHaddad]

Also there is a similar bug for when someone moves into the customization section.

Comment 10

[Akshat [:baka]]

(In reply to Mazin AlHaddad from comment #8)

Hi, sorry everyone! I originally planned to get this done quickly but I got busy with work and basically forgot about it. The bug is still reproducible as long as the DE doesn't enforce a minimum size. I believe this is because we don't set a geometry for the mContainer (it's only set on mShell). I've already written a patch and will hopefully have it tested by tomorrow (setting up the environment again).

Hello Mazin, can you explain what does this line means :

The bug is still reproducible as long as the DE doesn't enforce a minimum size

I was trying to understand the bug but couldn't. I am also new to both open source and mozilla, so it will be of great help in understanding the code base

Comment 11

[Mazin AlHaddad]

I'm honestly not a very good source of information but I believe Wayland compositors can specify a minimum size for windows. You can reproduce this bug on weston.

Comment 12

[Mazin AlHaddad]

Hi could I please get some extra guidance on this? I tried to use gdk_window_set_geometry_hints() along with the geometry hints used for mShell to no avail. Am I supposed to calculate the CSD decoration size for wayland (from my understanding everything is rendered to mContainer)? Any extra info would be helpful. Thank you and sorry if this is a horrible question!

Comment 13

[Christian Stadelmann]

(In reply to Akshat [:baka] from comment #7)

Created attachment 9194811 [details]
Alpha.png

Hello, I tried to reproduce this bug on my mozilla and to me minimum window size seems to be optimum. It is creating no problems. I am working on Ubuntu 20.04 and Firefox version 83.0a1 .

Can someone help me if I am missing something. And help me proceed with this bug.

For me it looks similar to your picture. At least the window controls can now be reached always in my setup (GNOME/Wayland). In other words: compared to my first screenshot, the situation improved a lot: I can always access window controls, address bar and the sandwich menu button.

I still feel like the window should be larger by default, especially the height is so small that you can only see one line of the address bar popup, but the current size is something I can live with. I am not used to the process here but if you want you can reduce priority from "bug"/"defect" to "request for enhancement".

Comment 14

[Christian Stadelmann]

Attachment: Screenshot with FF 84.0.2

Screenshot with Firefox 84.0.2 shows that the situation improved quite a lot compared to the initial bug report.

Comment 15

[Mazin AlHaddad]

Attachment: Bug 1612738 - Set minimum widget size for mContainer. r=stransky

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32e20e00382d
Set minimum widget size for mContainer. r=stransky

Comment 17

[Cosmin Sabou [:CosminS]]

Backed out for causing bc failures on browser_closePipPause.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&test_paths=toolkit%2Fcomponents%2Fpictureinpicture%2Ftests&revision=32e20e00382df853f83f07801d997e85416e5506&selectedTaskRun=U-dBbWgAQFC75JH4SRiaEQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=332206664&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/b2f492e1e19af9f9ce72b9c6712882757c39753d

Comment 18

[Bogdan Tara[:bogdan_tara | bogdant]]

Also seeing the following starting to permafail with the backed out changes: https://treeherder.mozilla.org/logviewer?job_id=332206634&repo=autoland&lineNumber=30609

Comment 19

[Narcis Beleuzu [:NarcisB]]

There are also multiple bc failures on browser/components/places/tests/browser/

https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Dwmy0QaASRCg53L3_a-36Q.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&classifiedState=classified&fromchange=7541959e175112bede994581296c327bde97ceb7&searchStr=linux%2C18.04%2Cx64%2Copt%2Cmochitests%2Ctest-linux1804-64%2Fopt-mochitest-browser-chrome-e10s%2Cbc2

Comment 20

[Martin Stránský [:stransky] (ni? me)]

I'm afraid we're blocked here with the testsuite. Not sure if the failures are valid or it's just a bug. Anyway, we may want to set the minimal size to mozcontainer on Wayland only so we may call the gtk_widget_set_size_request() only in !mIsX11Display case.

Mazin, do you mind to update the patch?
Thanks.

Comment 21

[Mazin AlHaddad]

Hi, I've updated and submitted the patch. I haven't used the automated test suite though, I'm trying to do that now.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/308c94d72017
Set minimum widget size for mContainer. r=stransky

Comment 23

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/308c94d72017