1612985 - Magnifer search icon is displayed when browser.discovery.enable is both true and false.

Status: RESOLVED INVALID

(Firefox :: Search, defect)

Description

[Clara Guerrero ( Need Info Brindusa Tot Please)]

1. Launch firefox nightly
2. open about:config
3. set browser.search.widget.inNavBar to true
   browser.discovery.enable* true
4. Visit facebook.com
5. Page is opened and the engine is discovered: signaled by the maginifer search icon and the plus in the search bar
6. Open about:config and set browser.discovery.enabled to false

Expected results: The Open Search engine is not discovered: signaled by the lack of the maginifer search icon and the plus in the search bar

Actual results: Engine is still discovered: the maginifer search icon is displayed.

See attachment for more details.

Comment 1

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Attachment: falseandtrue.webm

Comment 2

[Mark Banner (:standard8)]

As I understand it browser.discovery.enabled is all about the recommendations for various add-ons and things that sometimes get displayed in the address bar.

The search engine discovery is a different feature that has never had a pref.

Clara, where has the expectation that this preference affects the search engines come from?

Comment 3

[Adrian Florinescu [:aflorinescu]]

I can answer that for Clara. This comes from testrail . Initial, as preparation for Search Optimization, we've added added tests for Open Search autodiscovery, since this section wasn't covered by reccurent validation tests.

So, if browser.discovery.enabled has nothing to do with open search discovery, we can mark this as invalid and I'll also remove the test as being incorect. I don't recall exactly where this information came from, but apparently we hold off running this test before, probably pending confirmation if this is an issue or not - or might be possible that it was answered but I failed to follow-up on updating this testcase.

Comment 4

[Dale Harvey (:daleharvey)]

Yup this is definitely unrelated