1613041 - NullPointerException in GeckoRuntime.getRunningAppProcesses()

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Just saw this crash happening in a migration build. It only happened for one users so far - seems to be super rare.

java.lang.NullPointerException: Attempt to invoke interface method 'java.util.Iterator java.util.List.iterator()' on a null object reference
    at org.mozilla.geckoview.GeckoRuntime.getProcessName(GeckoRuntime.java:2)
    at org.mozilla.geckoview.GeckoRuntime.init(GeckoRuntime.java:5)
    at org.mozilla.geckoview.GeckoRuntime.create(GeckoRuntime.java:6)
    at GeckoProvider.createRuntime(GeckoProvider.kt:19)
    at GeckoProvider.getOrCreateRuntime(GeckoProvider.kt:2)
    at org.mozilla.fenix.components.Core$engine$2.invoke(Core.kt:32)
[...]

https://sentry.prod.mozaws.net/operations/fenix-fennec-nightly/issues/7186065

Related code:

   private static String getProcessName(final Context context) {
        final ActivityManager manager = (ActivityManager)context.getSystemService(Context.ACTIVITY_SERVICE);
        for (final ActivityManager.RunningAppProcessInfo info : manager.getRunningAppProcesses()) {

According to the docs getRunningAppProcesses() returns null instead of an empty list if there are no running processes (Great API). Not sure how/when that happens though.
https://developer.android.com/reference/android/app/ActivityManager#getRunningAppProcesses()

Comment 1

[Eugen Sawin [:esawin]]

Attachment: Bug 1613041 - [1.0] Handle null return for getRunningAppProcesses. r=#geckoview-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f095085e084
[1.0] Handle null return for getRunningAppProcesses. r=geckoview-reviewers,snorp

Comment 3

[Eugen Sawin [:esawin]]

Attachment: Bug 1613041 - [2.0] Add missing import.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/437fbc225b27
[2.0] Add missing import. a=bustage-fix

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/5f095085e084
https://hg.mozilla.org/mozilla-central/rev/437fbc225b27