Closed Bug 1613071 Opened 4 years ago Closed 4 years ago

Rename `RangeData` to `StyledRange` and move to separate file.

Categories

(Core :: DOM: Selection, enhancement)

Product:
Core
Component:
DOM: Selection
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mbrodesser-Igalia, Assigned: mbrodesser-Igalia)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1613071: rename `RangeData` to `StyledRange` and move it to separate file. r=smaug
47 bytes, text/x-phabricator-request
Details | Review
No description provided.

Breaks the dependency from Selection.h. Allows reuse for Selection
across the Shadow DOM boundary, which will require styled ranges to be
stored in DocumentOrShadowRoot too.

Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c68992f760e
rename `RangeData` to `StyledRange` and move it to separate file. r=smaug

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=6c68992f760eb8a001be16016ddf3105ddb3a98c&selectedJob=287457943

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=287457937&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/3bccd2f88e6a86b20b063f2c30b3a7c86be29482

[task 2020-02-04T14:36:03.327Z] 14:36:03 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/base'
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -o Unified_cpp_dom_base7.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -fno-common -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DHAVE_SIDEBAR -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/obj-firefox/dom/base -I/builds/worker/workspace/build/src/dom/battery -I/builds/worker/workspace/build/src/dom/events -I/builds/worker/workspace/build/src/dom/media -I/builds/worker/workspace/build/src/dom/network -I/builds/worker/workspace/build/src/caps -I/builds/worker/workspace/build/src/docshell/base -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/file -I/builds/worker/workspace/build/src/dom/geolocation -I/builds/worker/workspace/build/src/dom/html -I/builds/worker/workspace/build/src/dom/ipc -I/builds/worker/workspace/build/src/dom/storage -I/builds/worker/workspace/build/src/dom/svg -I/builds/worker/workspace/build/src/dom/u2f -I/builds/worker/workspace/build/src/dom/xml -I/builds/worker/workspace/build/src/dom/xslt/xpath -I/builds/worker/workspace/build/src/dom/xul -I/builds/worker/workspace/build/src/extensions/permissions -I/builds/worker/workspace/build/src/gfx/2d -I/builds/worker/workspace/build/src/image -I/builds/worker/workspace/build/src/js/xpconnect/loader -I/builds/worker/workspace/build/src/js/xpconnect/src -I/builds/worker/workspace/build/src/js/xpconnect/wrappers -I/builds/worker/workspace/build/src/layout/base -I/builds/worker/workspace/build/src/layout/forms -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/layout/style -I/builds/worker/workspace/build/src/layout/svg -I/builds/worker/workspace/build/src/layout/xul -I/builds/worker/workspace/build/src/netwerk/base -I/builds/worker/workspace/build/src/netwerk/url-classifier -I/builds/worker/workspace/build/src/security/manager/ssl -I/builds/worker/workspace/build/src/widget -I/builds/worker/workspace/build/src/xpcom/ds -I/builds/worker/workspace/build/src/netwerk/sctp/datachannel -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-aligned-new -fsanitize=bool,bounds,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound -fno-sanitize-recover=bool,bounds,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound -fsanitize-blacklist=/builds/worker/workspace/build/src/obj-firefox/ubsan_blacklist.txt -fsanitize=address -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/workspace/build/src/widget/gtk/compat-gtk3 -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gtk-3.0/unix-print -Wno-error=shadow -MD -MP -MF .deps/Unified_cpp_dom_base7.o.pp Unified_cpp_dom_base7.cpp
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - In file included from Unified_cpp_dom_base7.cpp:2:
[task 2020-02-04T14:36:03.337Z] 14:36:03 ERROR - /builds/worker/workspace/build/src/dom/base/XPathGenerator.cpp:57:11: error: unknown type name 'Element'; did you mean 'mozilla::dom::Element'?
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - const Element* elem = aNode->AsElement();
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - ^~~~~~~
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - mozilla::dom::Element
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Element.h:162:7: note: 'mozilla::dom::Element' declared here
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - class Element : public FragmentOrElement {
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - ^
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - In file included from Unified_cpp_dom_base7.cpp:2:
[task 2020-02-04T14:36:03.337Z] 14:36:03 ERROR - /builds/worker/workspace/build/src/dom/base/XPathGenerator.cpp:154:11: error: unknown type name 'Element'; did you mean 'mozilla::dom::Element'?
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - const Element* elem = aNode->AsElement();
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - ^~~~~~~
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - mozilla::dom::Element
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Element.h:162:7: note: 'mozilla::dom::Element' declared here
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - class Element : public FragmentOrElement {
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - ^
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - In file included from Unified_cpp_dom_base7.cpp:2:
[task 2020-02-04T14:36:03.337Z] 14:36:03 ERROR - /builds/worker/workspace/build/src/dom/base/XPathGenerator.cpp:167:14: error: unknown type name 'Element'; did you mean 'mozilla::dom::Element'?
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - for (const Element* e = aNode->GetPreviousElementSibling(); e;
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - ^~~~~~~
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - mozilla::dom::Element
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Element.h:162:7: note: 'mozilla::dom::Element' declared here
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - class Element : public FragmentOrElement {
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - ^
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - 3 errors generated.
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - /builds/worker/workspace/build/src/config/rules.mk:744: recipe for target 'Unified_cpp_dom_base7.o' failed
[task 2020-02-04T14:36:03.337Z] 14:36:03 ERROR - make[4]: *** [Unified_cpp_dom_base7.o] Error 1
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/base'
[task 2020-02-04T14:36:03.337Z] 14:36:03 INFO - make[4]: *** Waiting for unfinished jobs....

Flags: needinfo?(mbrodesser)

CosminS: thanks for notifying me. Submitted a new patch.

Flags: needinfo?(mbrodesser)
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7dc00529489
rename `RangeData` to `StyledRange` and move it to separate file. r=smaug

@apavel: the submitted change didn't break the linked failure, it didn't change functionality, just some code was moved. Moreover, the linked failure points to https://hg.mozilla.org/integration/autoland/rev/7554cfe059b4078b8b7e3a2d70d1363206cd3a21, which isn't the commit corresponding to the review of this bug.
Is it OK to push the review again, or did I miss something?

Flags: needinfo?(mbrodesser) → needinfo?(apavel)

(In reply to Mirko Brodesser (:mbrodesser) from comment #7)

@apavel: the submitted change didn't break the linked failure, it didn't change functionality, just some code was moved. Moreover, the linked failure points to https://hg.mozilla.org/integration/autoland/rev/7554cfe059b4078b8b7e3a2d70d1363206cd3a21, which isn't the commit corresponding to the review of this bug.
Is it OK to push the review again, or did I miss something?

Sorry about that, I posted in the wrong bug. Your changes were not backed out. I'll mark the comment as obsolete to avoid future confusion. Thanks for the ni.

Flags: needinfo?(apavel)

@apavel: no worries, thanks.

https://hg.mozilla.org/mozilla-central/rev/a7dc00529489

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: