1613192 - Fix non-unified build errors in layout/base and layout/generic

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Daniel Holbert [:dholbert]]

(previously: bugs like bug 1544897, bug 1590639)

layout/base and layout/generic don't quite build successfully right now, when I disable unified builds (by doing s/UNIFIED_SOURCES/SOURCES/ in their moz.build files)

Patch upcoming to address this.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1613192: Fix non-unified build bustage in layout/{base,generic} directories. r?TYLin

Summary of the changes/reasons:

• LayoutTelemetryTools.h directly uses several types whose headers it needs to
  include. (These headers are present in its .cpp file; I'm migrating them
  from there to the .h file.)

• LayoutTelemetryTools.cpp needs an include for MainThreadUtils.h, to provide
  NS_IsMainThread().

• StaticPresData.cpp needs an include for ServoUtils.h, to provide
  AssertIsMainThreadOrServoFontMetricsLocked().

• ZoomConstraintsClient.h needs a forward-decl for mozilla::dom::Document since
  it uses a pointer of that type in a function-decl.

• ScrollSnap.h needs forward-decls of nsPoint/nsRect for some references to
  those types in a method signature.

• nsGridContainerFrame.cpp needs an include for nsBoxLayoutState.h since it
  uses that type (it instantiates a nsBoxLayoutState instance).

• nsPlaceholderFrame.cpp needs a "using" decl for the mozilla::dom namespace in
  order to use the un-namespace-prefixed "Element" type.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/810acba57f37
Fix non-unified build bustage in layout/{base,generic} directories. r=TYLin

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/810acba57f37