1613247 - Simplify sccache credential logic.

Status: REOPENED

(Firefox Build System :: Task Configuration, task)

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1613247: Use calculated GCS bucket in mozconfig.cacche;

The code goes to some length to calculate the bucket to use, but then
hard-codes the bucket in the credential URL it uses.

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1613247: Simplify sccache config;

The logic for finding the sccache configuration to use has gone through several
iterations. At this point, all the build workers set
TASKCLUSTER_WORKER_LOCATION, so remove the code for dealing with other
configurations. Also don't set sccache configuration if it is disabled, even
if the bucket somehow gets set.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56c80f46fbe2
Use calculated GCS bucket in mozconfig.cacche; r=firefox-build-system-reviewers,chmanchester
https://hg.mozilla.org/integration/autoland/rev/c02a7a545a87
Simplify sccache config; r=firefox-build-system-reviewers,chmanchester

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/56c80f46fbe2
https://hg.mozilla.org/mozilla-central/rev/c02a7a545a87

Comment 5

[Razvan Maries]

Backed out https://hg.mozilla.org/integration/autoland/rev/c02a7a545a87e7d519dc8d36113ee05afcd8bde3 as per Tom's request: https://hg.mozilla.org/integration/autoland/rev/7619bde24a39fa788b4d000d655e5eb15d3a1835

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/7619bde24a39

Comment 7

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #3)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56c80f46fbe2
Use calculated GCS bucket in mozconfig.cacche;
r=firefox-build-system-reviewers,chmanchester
https://hg.mozilla.org/integration/autoland/rev/c02a7a545a87
Simplify sccache config; r=firefox-build-system-reviewers,chmanchester

== Change summary for alert #24890 (as of Fri, 07 Feb 2020 23:22:07 GMT) ==

Improvements:

29% build times windows2012-64 asan opt taskcluster-c4.4xlarge 4,081.30 -> 2,889.99
28% build times windows2012-aarch64 debug aarch64 taskcluster-c4.4xlarge 3,356.13 -> 2,412.30
28% build times windows2012-64 asan fuzzing-asan taskcluster-c4.4xlarge 4,108.36 -> 2,977.35
27% build times windows2012-64 debug fuzzing taskcluster-c4.4xlarge 3,783.70 -> 2,759.67
27% build times windows2012-32 debug taskcluster-c4.4xlarge 3,730.45 -> 2,722.22
27% build times windows2012-32 opt taskcluster-c4.4xlarge 3,599.14 -> 2,631.11
26% build times windows2012-64 debug taskcluster-c4.4xlarge 3,788.17 -> 2,785.32
26% build times windows2012-64 opt taskcluster-c4.4xlarge 3,614.07 -> 2,657.60
26% build times windows2012-64 asan debug taskcluster-c4.4xlarge 4,371.46 -> 3,224.80
23% build times windows2012-64 asan opt taskcluster-c5.4xlarge 3,328.08 -> 2,547.35
23% build times windows2012-64 opt taskcluster-c5.4xlarge 2,835.28 -> 2,172.18
23% build times windows2012-64 asan fuzzing-asan taskcluster-c5.4xlarge 3,376.57 -> 2,603.76
22% build times windows2012-64 debug taskcluster-c5.4xlarge 2,774.45 -> 2,162.58
22% build times windows2012-32 opt taskcluster-c5.4xlarge 2,841.43 -> 2,220.09
21% build times windows2012-64 asan debug taskcluster-c5.4xlarge 3,625.79 -> 2,873.15
20% build times windows2012-64 debug fuzzing taskcluster-c5.4xlarge 2,817.57 -> 2,247.81
20% build times windows2012-32 debug taskcluster-c5.4xlarge 2,728.86 -> 2,183.32
17% build times windows2012-aarch64 debug aarch64 taskcluster-c5.4xlarge 2,491.17 -> 2,070.73
14% build times windows2012-aarch64 opt aarch64 taskcluster-c4.4xlarge 4,095.94 -> 3,518.33

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24890

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.