Closed Bug 1613253 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21585 - Fixed initialization of animation hold time when scroll timeline is inactive

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox75 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21585 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21585
Details from upstream follow.

Olga Gerchikov <gerchiko@microsoft.com> wrote:

Fixed initialization of animation hold time when scroll timeline is inactive

https://chromium-review.googlesource.com/c/chromium/src/+/1945923
change erroneously initializes hold_time_ to null when scroll
timeline is inactive. This makes assert to fail in
Animation::CommitPendingPlay at:
DCHECK(start_time_ || hold_time_);

Bug: 1042924
Change-Id: I98060d065da93bb633d6cbc1506c591194a11692
Reviewed-on: https://chromium-review.googlesource.com/2037348
WPT-Export-Revision: 505cfd71628a991d61ce399aea4e138630a0a9dd

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
FAIL: 4

Chrome

OK : 1
PASS: 4

Safari

OK : 1
FAIL: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/scroll-animations/scroll-animation.html
Animation start and current times are correct if scroll timeline is activated after animation.play call.: FAIL (Chrome: PASS, Safari: FAIL)
Animation start and current times are correct for each animation state when the animation starts playing with advanced scroller.: FAIL (Chrome: PASS, Safari: FAIL)
Animation start and current times are correct when multiple animations are attached to the same timeline.: FAIL (Chrome: PASS, Safari: FAIL)
Animation start and current times are correct for each animation state.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/859a7bb88b63
[wpt PR 21585] - Fixed initialization of animation hold time when scroll timeline is inactive, a=testonly
https://hg.mozilla.org/integration/autoland/rev/98d2c9e64a16
[wpt PR 21585] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/859a7bb88b63
https://hg.mozilla.org/mozilla-central/rev/98d2c9e64a16

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.