1613263 - mozbuild/preprocessor.py uses io.open() rather than open()

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Ricky Stewart]

Attachment: Bug 1613263 - Use io.open() rather than open() in mozbuild/preprocessor.py

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54f82c735487
Use io.open() rather than open() in mozbuild/preprocessor.py r=firefox-build-system-reviewers,mshal

Comment 3

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 54f82c735487 (Bug 1613263) for causing diff artifact bustages in generated-files.diff.txt CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=288626312

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288626312&repo=autoland&lineNumber=7058

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f205d029f74
Backed out changeset 54f82c735487 for causing diff artifact bustages in generated-files.diff.txt CLOSED TREE

Comment 5

[Mike Hommey [:glandium]]

Note there are two problems in the failed build: one is that bug 1597903 broke how those jobs fail if there are differences, and the other is that there are differences in what looks like line endings between the artifact build and the normal build.

Comment 6

[Mike Hommey [:glandium]]

Filed bug 1615150 for the former.

Comment 7

[Ricky Stewart]

Updated the revision and diffoscope is green in the try push, so I'm re-landing now.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36ba18ac3a68
Use io.open() rather than open() in mozbuild/preprocessor.py r=firefox-build-system-reviewers,mshal

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/36ba18ac3a68

Comment 10

[Cosmin Sabou [:CosminS]]

Comment 9 or Bug 1611326 https://hg.mozilla.org/mozilla-central/rev/77e54e76848 caused these l10n bustages so we decided to backout both of them: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=ccbbd26e4bec0cda9a2d4e4b73de319092569c28&searchStr=l10n&selectedJob=288917169

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=288917169&repo=mozilla-central

Backout link: https://hg.mozilla.org/mozilla-central/rev/ca97340e64722330f45043b3fa8a819ad7c59835

Comment 11

[Ricky Stewart]

Updated revision is succeeding l10n in try, so re-landing now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=35a57bb9e0def62720cb68cee1f35fb3e936e22b

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/061442a5cbbf
Use io.open() rather than open() in mozbuild/preprocessor.py r=firefox-build-system-reviewers,mshal

Comment 13

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/061442a5cbbf