1613285 - Text decorations look off with latest builds.

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: Screenshot of spelling markers.

Mozregression says https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=965511d602e38f5fdc7bd6671f6f28be2975f927&tochange=2614c67d7e65ab704e722437726c5b60a969e3c6.

Searchfox is a clear example of this. This is I believe a hidpi issue (offset being half of what it should be), because spelling markers also look off.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Searchfox underline.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Ah, ditch that hidpi issue. I think this piece of code got lost during the refactor:

  // If offset is `auto`, we clamp the offset (in horizontal typographic mode)
  // to a minimum of 1/16 em (equivalent to 1px at font-size 16px) to mitigate
  // skip-ink issues with fonts that leave the underlineOffset field as zero.
  if (aOffset.IsAuto()) {
    if (!aParams.vertical || aIsSideways) {
      aParams.offset =
          std::min(aParams.offset, gfx::Float(-aFontMetrics.emHeight / 16.0));
    // ...

I can fix.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1613285 - Reintroduce the skip-ink mitigation lost during bug 1612822. r=jfkthame

I should've caught this during review, sorry :(

Note that try is closed atm so untested, but this does fix the issue.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/332b09a9811f
Reintroduce the skip-ink mitigation lost during bug 1612822. r=jfkthame

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/332b09a9811f