1613316 - Crash in [@ webrender::picture::TileCacheInstance::pre_update]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Julien Cristau [:jcristau]]

This bug is for crash report bp-d905206a-7293-4e9f-9b97-e36450200205.

Panics with "called Option::unwrap() on a None value" since yesterday's nightly build 20200204095729.

Top 10 frames of crashing thread:

0 xul.dll RustMozCrash mozglue/static/rust/wrappers.cpp:16
1 xul.dll mozglue_static::panic_hook mozglue/static/rust/lib.rs:89
2 xul.dll core::ops::function::Fn::call<fn src/libcore/ops/function.rs:227
3 xul.dll std::panicking::rust_panic_with_hook src/libstd/panicking.rs:477
4 xul.dll std::panicking::continue_panic_fmt src/libstd/panicking.rs:380
5 xul.dll std::panicking::rust_begin_panic src/libstd/panicking.rs:307
6 xul.dll core::panicking::panic_fmt src/libcore/panicking.rs:85
7 xul.dll core::panicking::panic src/libcore/panicking.rs:49
8 xul.dll webrender::picture::TileCacheInstance::pre_update gfx/wr/webrender/src/picture.rs
9 xul.dll webrender::prim_store::PrimitiveStore::update_visibility gfx/wr/webrender/src/prim_store/mod.rs:1903

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Glenn, Jim, bug 1608280 and bug 157974 landed in build 20200204095729, could one of those have caused this regression? Thanks

Comment 2

[Glenn Watson [:gw]]

It is possibly caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1608280 (there is an unwrap call in that part of the code, although if that is being hit, it means something else is going wrong earlier).

I think the other possible bug you linked is an incorrect link (very old bug number and seems unrelated)?

Do we have a repro / URL steps for this?

Comment 3

[Julien Cristau [:jcristau]]

Sent URL data from crash reports out of band. I can't help with STR since the report is based off seeing this in crash-stats.

Comment 4

[Julien Cristau [:jcristau]]

I'll note that based on crash volume in nightly we probably don't want to let this merge to beta next week, so might have to backout.

Comment 5

[Glenn Watson [:gw]]

I can reproduce this locally now, should have a fix for it today.

Comment 6

[Glenn Watson [:gw]]

Attachment: Bug 1613316 - Fix panic in TileCache::pre_update.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1568adc54fd
Fix panic in TileCache::pre_update. r=Bert

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f1568adc54fd

Comment 9

[Firefox Bug Husbandry Bot]

Please specify a root cause for this bug. See :tmaity for more information.