1613320 - Tooltip is not displayed when the user hover the mouse over the protection panel shield icon in the highlighted area

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P3)

Description

[Alin Ilea, Desktop QA]

Attachment: Hover issue.mp4

Affected versions:

ALL

Affected platforms:

ALL

Steps:

1. Launch Firefox with a new profile access any website e.g www.wikipedia.org
2. Hover with the mouse over the shield icon near the address bar, in the highlighted area but not right on the shield icon.

Actual result:

The shield icon is highlighted but the tooltip is displayed only if the user hover the mouse cursor exactly on the shield icon. If hover the mouse in the highlighted zone but not directly on the shield icon the tooltip is not displayed.

Expected result:

The tooltip should be displayed when the user hover the mouse anywhere in the highlighted area, like on the other buttons or menus.
Please see the video attachment for a better understanding.

Comment 1

[Erica Wright [:ewright]]

It looks like the tooltip attribute is on the inner box with id=tracking-protection-icon-box, instead of the outer box with id=tracking-protection-icon-container. This would be a good first bug, labelling it as such, and happy to mentor/review.

Comment 2

[Barbara]

Hi Erica,

I am interested in contributing to this bug. Where should I start?

Thanks!

Comment 3

[Erica Wright [:ewright]]

Barbara, Absolutely!
Have you worked with Firefox before? If not you can follow the guide to start building Firefox for desktop: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions

There's more instructions on contributing and putting your code up for review on Phabricator here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction

The code you'll be looking at is in this file: https://searchfox.org/mozilla-central/source/browser/base/content/browser.xhtml#851

I'll assign you to the bug after you post a patch.
Feel free to email me with further questions ([e-mail]).

Comment 4

[Theo Ottah]

Hi Erica,

Is this no longer being worked on? I'd like to pick this up.

Comment 5

[Johann Hofmann [:johannh]]

Hi Theo, Erica is away until March 11 but I'm happy to help. I think you should feel free to pick this up.

Comment 6

[Theo Ottah]

Hi Johann,

I've fixed the bug last night. Going going to read the docs on submitting patches tonight and will hopefully have pushed the patch by tomorrow.

Comment 7

[Johann Hofmann [:johannh]]

Great, thanks! Feel free to tag me as reviewer.

Comment 8

[Theo Ottah]

Attachment: Bug 1613320 - Display tooltip when hovering over protection panel highlight area

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/458075843d46
Display tooltip when hovering over protection panel highlight area r=johannh

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/458075843d46

Comment 11

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Nightly 75.0a1 (build id: 20200304084140) using Windows 10, Mac OS 10.15 and Ubuntu 18.04.