161333 - js warning / perf improvement in msgMail3PaneWindow.js, GetFirstSelectedMessage()

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

the checkin for #30560 causes js warnings when there are no selected messages 
in the thread pane.

it's also not as efficent as it could be.

Here's a patch that gets ride of the js warning, and includes a comment on how 
to make it more efficient.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: start of the fix.

Comment 2

[David :Bienvenu]

Comment on attachment 94207 [details] [diff] [review]
start of the fix.

r/sr=bienvenu

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: new patch, better comment

in the existing code, ssu has:

// Use this instead of gDBView.URIForFirstSelectedMessage
// will return the currentIndex message instead of the highlighted
// message.

so I've fixed the js strict warning, but left the XXX todo to indicate that
this might be a perf issue when there are a lot of messages selected.

Comment 4

[Samir Gehani]

Mail triage team: nsbeta1+/adt3

Comment 5

[[e-mail]]

Attachment: Fix perf issue

This also fixes bug 82056.

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 111830 [details] [diff] [review]
Fix perf issue

r/sr=sspitzer

Comment 7

[(not reading, please use [e-mail] instead)]

re-assign to neil

Comment 8

[(not reading, please use [e-mail] instead)]

not sure why this got nsbeta1+.  (maybe because it had perf in the summary?)

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 111830 [details] [diff] [review]
Fix perf issue

r=dmose

Comment 10

[[e-mail]]

Fix checked in.

Comment 11

[esther]

Using trunk build 20030515 on winxp, linux and mac osx this is fixed. Verified.