js warning / perf improvement in msgMail3PaneWindow.js, GetFirstSelectedMessage()

VERIFIED FIXED in mozilla1.3beta

Status

SeaMonkey
MailNews: Message Display
VERIFIED FIXED
16 years ago
13 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
mozilla1.3beta
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [adt3])

Attachments

(2 attachments, 1 obsolete attachment)

the checkin for #30560 causes js warnings when there are no selected messages 
in the thread pane.

it's also not as efficent as it could be.

Here's a patch that gets ride of the js warning, and includes a comment on how 
to make it more efficient.

Comment 2

16 years ago
Comment on attachment 94207 [details] [diff] [review]
start of the fix.

r/sr=bienvenu
Attachment #94207 - Flags: superreview+
Created attachment 94301 [details] [diff] [review]
new patch, better comment

in the existing code, ssu has:

// Use this instead of gDBView.URIForFirstSelectedMessage
// will return the currentIndex message instead of the highlighted
// message.

so I've fixed the js strict warning, but left the XXX todo to indicate that
this might be a perf issue when there are a lot of messages selected.
Attachment #94207 - Attachment is obsolete: true
Keywords: nsbeta1, patch, review
QA Contact: olgam → stephend

Comment 4

15 years ago
Mail triage team: nsbeta1+/adt3
Keywords: nsbeta1 → nsbeta1+
Whiteboard: [adt3]
(Assignee)

Comment 5

15 years ago
Created attachment 111830 [details] [diff] [review]
Fix perf issue

This also fixes bug 82056.
(Assignee)

Updated

15 years ago
Attachment #111830 - Flags: superreview?(sspitzer)
Attachment #111830 - Flags: review?(ssu)
Comment on attachment 111830 [details] [diff] [review]
Fix perf issue

r/sr=sspitzer
Attachment #111830 - Flags: superreview?(sspitzer) → superreview+
re-assign to neil
Assignee: ssu → neil
not sure why this got nsbeta1+.  (maybe because it had perf in the summary?)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.3beta

Comment 9

15 years ago
Comment on attachment 111830 [details] [diff] [review]
Fix perf issue

r=dmose
Attachment #111830 - Flags: review?(ssu) → review+
(Assignee)

Comment 10

15 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 11

15 years ago
Using trunk build 20030515 on winxp, linux and mac osx this is fixed. Verified.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.