the checkin for #30560 causes js warnings when there are no selected messages in the thread pane. it's also not as efficent as it could be. Here's a patch that gets ride of the js warning, and includes a comment on how to make it more efficient.
Comment on attachment 94207 [details] [diff] [review] start of the fix. r/sr=bienvenu
Attachment #94207 - Flags: superreview+
Created attachment 94301 [details] [diff] [review] new patch, better comment in the existing code, ssu has: // Use this instead of gDBView.URIForFirstSelectedMessage // will return the currentIndex message instead of the highlighted // message. so I've fixed the js strict warning, but left the XXX todo to indicate that this might be a perf issue when there are a lot of messages selected.
Attachment #94207 - Attachment is obsolete: true
Keywords: nsbeta1, patch, review
QA Contact: olgam → stephend
Mail triage team: nsbeta1+/adt3
Keywords: nsbeta1 → nsbeta1+
Comment on attachment 111830 [details] [diff] [review] Fix perf issue r/sr=sspitzer
Attachment #111830 - Flags: superreview?(sspitzer) → superreview+
re-assign to neil
Assignee: ssu → neil
15 years ago
not sure why this got nsbeta1+. (maybe because it had perf in the summary?)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.3beta
Comment on attachment 111830 [details] [diff] [review] Fix perf issue r=dmose
Attachment #111830 - Flags: review?(ssu) → review+
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Using trunk build 20030515 on winxp, linux and mac osx this is fixed. Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.