1613340 - Remove const_cast from IndexedDB

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, task, P3)

Description

[Simon Giesecke [:sg] [he/him]]

const_cast bears the danger of undefined behaviour. This should be removed from IndexedDB code where possible. Several of the uses const_cast are related to IPDL generated methods, which can be de-virtualized now.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1613340 - Remove const_cast relating to DatabaseSpec. r=#dom-workers-and-storage

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1613340 - Remove const_cast relating to ObjectStoreSpec. r=#dom-workers-and-storage

Depends on D61668

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1613340 - Remove const_cast relating to StructuredCloneReadInfo. r=#dom-workers-and-storage

Depends on D61669

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1613340 - Remove const_cast relating to SerializedStructuredCloneReadInfo. r=#dom-workers-and-storage,jld

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1613340 - Remove const_cast relating to CursorResponse. r=#dom-workers-and-storage,jld

Depends on D61671

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54432e819f8f
Remove const_cast relating to DatabaseSpec. r=dom-workers-and-storage-reviewers,edenchuang
https://hg.mozilla.org/integration/autoland/rev/e77b18fdf915
Remove const_cast relating to ObjectStoreSpec. r=dom-workers-and-storage-reviewers,edenchuang
https://hg.mozilla.org/integration/autoland/rev/01235f908545
Remove const_cast relating to StructuredCloneReadInfo. r=dom-workers-and-storage-reviewers,edenchuang
https://hg.mozilla.org/integration/autoland/rev/193b829f4c0e
Remove const_cast relating to SerializedStructuredCloneReadInfo. r=jld,dom-workers-and-storage-reviewers,edenchuang
https://hg.mozilla.org/integration/autoland/rev/a1d04bf539f1
Remove const_cast relating to CursorResponse. r=jld,dom-workers-and-storage-reviewers,edenchuang

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/54432e819f8f
https://hg.mozilla.org/mozilla-central/rev/e77b18fdf915
https://hg.mozilla.org/mozilla-central/rev/01235f908545
https://hg.mozilla.org/mozilla-central/rev/193b829f4c0e
https://hg.mozilla.org/mozilla-central/rev/a1d04bf539f1