1613349 - Make nsIFrame::RemoveProperty `MOZ_MUST_USE`.

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

https://phabricator.services.mozilla.com/D61142 introduced a leak because it used RemoveProperty rather than DeleteProperty on a deletable property and ignored the result.

That shouldn't happen.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1613349 - Make nsIFrame::RemoveProperty MOZ_MUST_USE. r=TYLin,dholbert

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1613349 - Rename nsIFrame::RemoveProperty to nsIFrame::TakeProperty. r=dholbert

This is hopefully clearer naming.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1613349 - Rename nsINode::UnsetProperty to nsINode::TakeProperty. r=smaug

For consistency with the previous change for layout.

Depends on D61755

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1613349 - Make nsIFrame::TakeProperty MOZ_MUST_USE. r=dholbert

Depends on D61756

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1613349 - Rename nsIFrame::DeleteProperty to RemoveProperty. r=dholbert

As it doesn't necessarily call delete and that may be confusing.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1613349 - Rename nsINode::DeleteProperty to RemoveProperty. r=smaug

And the related methods as well.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/310ae5b1a209
Rename nsIFrame::RemoveProperty to nsIFrame::TakeProperty. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/5146f19f9e31
Rename nsINode::UnsetProperty to nsINode::TakeProperty. r=smaug
https://hg.mozilla.org/integration/autoland/rev/6eb761359b54
Make nsIFrame::TakeProperty MOZ_MUST_USE. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/1e2ba9e0ea1a
Rename nsIFrame::DeleteProperty to RemoveProperty. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/3cfff4ea7fcb
Rename nsINode::DeleteProperty to RemoveProperty. r=smaug

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1613349 - Address one review comment I missed.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/078bc81f9525
Address one review comment I missed.

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/310ae5b1a209
https://hg.mozilla.org/mozilla-central/rev/5146f19f9e31
https://hg.mozilla.org/mozilla-central/rev/6eb761359b54
https://hg.mozilla.org/mozilla-central/rev/1e2ba9e0ea1a
https://hg.mozilla.org/mozilla-central/rev/3cfff4ea7fcb
https://hg.mozilla.org/mozilla-central/rev/078bc81f9525