1613356 - Can't explore data for storage empty with empty key

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open the console
2. Evaluate localStorage.setItem("", "{a: 20}");localStorage.setItem("key", "{a: 20}");
3. Open the storage inspector and select the local storage entry
4. Click on the line with the empty string key

Expected results

The sidebar with the parse value is displayed

Actual results

Clicking does not do anything

---

You can see the expected behavior by clicking on the "key" item

Comment 1

[Micah [:mtigley] (she/her)]

Quickly looking at this, it looks like the issue is coming from the ui's updateObjectSidebar method. Using the debugger I observed that this.table.selectedRow is undefined, which causes updateObjectSide to return early and not display the sidebar.

Digging further it looks like the TableWidget's selectedRow setter is expecting the selected row ID to be an object, but it's an empty string here. So the selectedRow is set to null.

I'm not familar with how TableWidget works. But perhaps finding where and how the Storage panel's table items are being set and consumed by the TableWidget might be the place to start.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can still reproduce the issue on my machine.

Honza

Comment 3

[Sebastian Zartner [:sebo]]

This sounds like the same problem as in bug 1671625. Maybe they should be merged?

Sebastian

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

We may keep both open just to make sure we cover both issues (localStorage and indexedDb)

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Sounds good, let's keep both open (they already block the same meta bug 1667980)

Thanks Sebastian for helping with the triage.

Honza

Comment 6

[Sebastian Zartner [:sebo]]

Attachment: Bug 1613356 - Fixed storage data inspection for empty strings. r=ladybenko

Comment 7

[Sebastian Zartner [:sebo]]

Attachment: Bug 1613356 - Added test case for storage key names. r=ladybenko

Depends on D110773

Comment 9

[Sebastian Zartner [:sebo]]

The attached patch indeed fixes the bug for all storage types, also for the indexedDB entries. Therefore I've now made the other bug a duplicate of this one.

Sebastian

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b62be4ffa2f
Fixed storage data inspection for empty strings. r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/0d62a4c90040
Added test case for storage key names. r=ladybenko

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6b62be4ffa2f
https://hg.mozilla.org/mozilla-central/rev/0d62a4c90040