Closed Bug 1613391 Opened 2 years ago Closed 2 years ago

Remove unnecessary moz.build files in console tests

Categories

(DevTools :: Console, task)

task
Not set
normal

Tracking

(firefox74 fixed)

RESOLVED FIXED
Firefox 74
Tracking Status
firefox74 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

Attachments

(1 file)

No description provided.

Having test files in moz.build meant we were shipping those in Firefox.
The better way of doing this is to add those files as support files,
and then load them through a chrome:// url.
The catch is that support files from another folder than the ini files
they are referenced in need to be referenced in an ini file in their
own folder.
And since we can't have a ini file without tests, we need to add a dummy
test in devtools/client/webconsole/test/node/fixtures/stubs/ . The "test"
is always skipped so it shouldn't have any impact.

Doing this work revealed an issue with NetworkEvent stubs, which were
out of sync, and not properly writter since Bug 1579090.
This patch fixes this as well, and we're lucky the node tests are still
passing fine.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fde540977b4e
Remove unnecessary moz.build files in console tests. r=jdescottes.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in before you can comment on or make changes to this bug.