Closed Bug 1613483 Opened 5 years ago Closed 5 years ago

Add cold pageload Fenix Browsertime pageload tests to Fenix branch

Categories

(Testing :: Raptor, task, P1)

Version 3
task

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sparky, Assigned: sparky)

References

Details

Attachments

(1 file)

See blocking bug for information. This bug is for adding cold page load tests running through Browsertime to the Fenix repo. It will involve getting them working and landing any work to make them work.

After that, they will need to be defined here: https://github.com/mozilla-mobile/fenix/blob/master/taskcluster/ci/raptor/kind.yml#L81

Their raptor transform might also need to be modified to handle browsertime: https://github.com/mozilla-mobile/fenix/blob/master/taskcluster/fenix_taskgraph/transforms/raptor.py

Then setting up the cron job here: https://github.com/mozilla-mobile/fenix/blob/master/.cron.yml#L21

You'll likely also need to modify the target task method here: https://github.com/mozilla-mobile/fenix/blob/master/taskcluster/fenix_taskgraph/target_tasks.py#L53

Note that these are just very vague steps of what needs to be done.

Over on bug 1613487 you only selected amazon and youtube. I assume this doesn't apply here, and all the tests have to be enabled on the github repo?

Flags: needinfo?(gmierz2)

Yes, all the tests that you see in these pushes: https://treeherder.mozilla.org/#/jobs?repo=fenix&tier=1%2C2%2C3&searchStr=raptor&fromchange=02b4582c8d2c425b1bcf83fd0956d17425d5c7e0

It might make more sense to start with the mozilla-central transition and then moving to this one.

Flags: needinfo?(gmierz2)

Something I just realized is that the visual metrics tasks are going to need to run on the Fenix branch. This might add some complexity to the issue given that they are dynamically built with transforms - maybe it won't be too difficult, but I'd prefer to call this out now rather than later.

I've started this work in this issue: https://github.com/mozilla-mobile/fenix/pull/8780

Assignee: nobody → gmierz2
Status: NEW → ASSIGNED
Priority: P2 → P1

Hey Greg, what about bug 1613487. Shouldn't that be done first given that it blocks this bug?

Flags: needinfo?(gmierz2)

The tests have been added to mozilla-central, but we just need to enable/migrate them so that work is nearly complete. I plan to make a patch for that change once we get further along here. Right now, we're blocked on bug 1619795 here.

Depends on: 1619795
Flags: needinfo?(gmierz2)
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

The cron task fails:

https://treeherder.mozilla.org/logviewer.html#?job_id=293597038&repo=fenix

Johan, can you check what scope is missing here, please?

[task 2020-03-18T01:02:38.431Z] ---
[task 2020-03-18T01:02:38.431Z]
[task 2020-03-18T01:02:38.431Z] * method: createTask
[task 2020-03-18T01:02:38.431Z] * errorCode: InsufficientScopes
[task 2020-03-18T01:02:38.431Z] * statusCode: 403
[task 2020-03-18T01:02:38.431Z] * time: 2020-03-18T01:02:38.743Z
[task 2020-03-18T01:02:38.458Z] Traceback (most recent call last):
[task 2020-03-18T01:02:38.459Z] File "/builds/worker/.local/lib/python2.7/site-packages/taskgraph/main.py", line 480, in main
[task 2020-03-18T01:02:38.459Z] args.command(vars(args))
[task 2020-03-18T01:02:38.459Z] File "/builds/worker/.local/lib/python2.7/site-packages/taskgraph/main.py", line 320, in decision
[task 2020-03-18T01:02:38.459Z] taskgraph_decision(options)
[task 2020-03-18T01:02:38.460Z] File "/builds/worker/.local/lib/python2.7/site-packages/taskgraph/decision.py", line 113, in taskgraph_decision
[task 2020-03-18T01:02:38.460Z] create_tasks(tgg.graph_config, tgg.morphed_task_graph, tgg.label_to_taskid, tgg.parameters)
[task 2020-03-18T01:02:38.460Z] File "/builds/worker/.local/lib/python2.7/site-packages/taskgraph/create.py", line 107, in create_tasks
[task 2020-03-18T01:02:38.461Z] f.result()
[task 2020-03-18T01:02:38.461Z] File "/usr/local/lib/python2.7/dist-packages/concurrent/futures/_base.py", line 455, in result
[task 2020-03-18T01:02:38.461Z] return self.__get_result()
[task 2020-03-18T01:02:38.462Z] File "/usr/local/lib/python2.7/dist-packages/concurrent/futures/thread.py", line 63, in run
[task 2020-03-18T01:02:38.462Z] result = self.fn(*self.args, **self.kwargs)
[task 2020-03-18T01:02:38.462Z] File "/builds/worker/.local/lib/python2.7/site-packages/taskgraph/create.py", line 133, in create_task
[task 2020-03-18T01:02:38.462Z] res.raise_for_status()
[task 2020-03-18T01:02:38.463Z] File "/usr/local/lib/python2.7/dist-packages/requests/models.py", line 940, in raise_for_status
[task 2020-03-18T01:02:38.463Z] raise HTTPError(http_error_msg, response=self)
[task 2020-03-18T01:02:38.463Z] HTTPError: 403 Client Error: Forbidden for url: http://taskcluster/queue/v1/task/NCgdtLVOSNebu4pLya3DQg

Status: RESOLVED → REOPENED
Flags: needinfo?(jlorenzo)
Resolution: FIXED → ---

Yes! I'm sorry for this failure, I thought these scopes were given to any new cron graph. The patch in comment 9 takes care of this!

Flags: needinfo?(jlorenzo)

No worries, thanks a lot for taking care of this :jlorenzo!

Blocks: 1623601

I confirm the cron decision task doesn't break anymore 🙂 https://treeherder.mozilla.org/#/jobs?repo=fenix&revision=756b1fbadd7b5aca72167982c600dc540552be04&selectedJob=293857308

I see Greg opened bug 1623601. Let's track the remaining work there and close this current bug. Please reopen if you don't agree 🙂

Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: