1613517 - Make rustc generate better code for derive(Animate) and derive(ComputeSquaredDistance).

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

See https://github.com/rust-lang/rust/issues/68867.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1613517 - Make rust generate better code for derive(Animate) and derive(ComputeSquaredDistance). r=heycam

See https://github.com/rust-lang/rust/issues/68867.

This technically changes the semantics of #[animate(fallback)] and such when
combined with #[animate(error)]. But no such combination exists and the new
semantics are perfectly reasonable as well, IMHO.

Comment 2

[Cameron McCormack (:heycam)]

Boris, #[animate(fallback)] isn't used at the moment -- do we have plans to use this, or can it be removed?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd4711d31ec6
Make rust generate better code for derive(Animate) and derive(ComputeSquaredDistance). r=heycam

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bd4711d31ec6

Comment 5

[Boris Chiou [:boris]]

(In reply to Cameron McCormack (:heycam) from comment #2)

Boris, #[animate(fallback)] isn't used at the moment -- do we have plans to use this, or can it be removed?

It's just a temporary solution when working on Stylo. We can remove it if we don't use it anymore. (I can file a bug to update it.)