1613535 - Handle message attachments in browser.compose API functions

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Comment 1

[Óvári]

1. Could the attachments be saved as a template attachment, i.e the file name being:
   {{attach_1}}
   {{attach_2}}
   ...
   {{attach_n}}
   Where the {{attach_x}} could be empty?

2. Could the {{attach_x}} also be an set of attachments?

This could help with the Mail Merge add-on as then the attachment could be stored with the email. This could help stop accidentally sending emails with attachment from other mail merges.

What do you think?

Thank you

Comment 2

[Geoff Lankow (:darktrojan)]

I'm not sure that I completely understand what you're asking for, but I'll explain what I have in mind at the moment as that might help.

• A listAttachments function which returns the attachments as File objects. I'm not sure if File does everything we need it to but I think it covers most bases: name, size, contents. There's also the question about what to do with FileLink attachments. I don't know, but the answer could be useful for comment 1. I had in mind that the attachments would be automatically listed in the onBeforeSend event and other events, but now I'm not so sure.
• An addAttachment function. If we're using File this would be great for extension-generated attachments. For using files from the filesystem, we'll first need to figure out what we're doing in terms of filesystem access APIs. There's discussion about that elsewhere so I won't go into it.
• A removeAttachment function and (I guess) an updateAttachment function.
• A onAttachmentAdded/Removed/other events, maybe. I'm not sure how useful it would be to know when attachments are removed from a draft.

Comment 3

[Óvári]

Attachment: Template in the attach bucket

Bug 1468704 Enable attaching a Template when creating a message
Please see the image Template in the attach bucket

Comment 4

[Magnus Melin [:mkmelin]]

When referencing bugs, please just use "bug" and the number so bugzilla can autolink them properly.

Comment 5

[Óvári]

bug 1468704

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1613535-api-attachments-1.diff

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9145732 [details] [diff] [review]
1613535-api-attachments-1.diff

Review of attachment 9145732 [details] [diff] [review]:
-----------------------------------------------------------------

I wonder if we should accept Blob too

Comment 8

[Geoff Lankow (:darktrojan)]

The only difference would be that you don't have to provide a file name, but you have to provide a name for the attachment (one way or another) anyway.

Comment 9

[Óvári]

Have we understood correctly that this would enable fields, eg. {{field_name}} and image shown in https://bugzilla.mozilla.org/show_bug.cgi?id=1613535#c3, to be provided as a name for the attachment without providing a file name?

This would be fantastic for the Mail Merge feature.

Thank you

Comment 10

[Geoff Lankow (:darktrojan)]

You'll be able to add attachments with a custom name, or rename existing ones to have a custom name, so yes, I think this can do what you want.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/10edd0b97102
Handle message attachments in browser.compose API functions. r=mkmelin

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d99e95524b9b
followup to fix linting. rs=eslint DONTBUILD

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2a5f7a05bc2c
follow-up - Fix "this.forgetAttachment is not a function" when closing compose window. rs=me DONTBUILD