1613566 - the root scrollbar thumb dragging is somewhat broken in fission

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

I have totally no idea what happens there.

STR

1. Make sure "Restore tabs" is enabled in about:preferences
2. Open https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API#Thresholds
3. Close browser window
4. Open a new browser process with enabling fission
5. Drag the scrollbar thumb to scroll up and down

Actually result
Scroll position jumps to the end and jumps back repeatedly

Reloading the page fixed this issue for some reasons.

I am not sure IntersectionObserver is needed to reproduce this issue, but as far as I can tell I haven't seen this issue on other pages.

Comment 1

[Jonathan Watt [:jwatt]]

Smaug, do you or any of the other people working on session history just now have any idea what may be happening here?

Comment 2

[Chris Peterson [:cpeterson]]

The test page does use cross-origin iframes.

Tracking for Fission Nightly (M6)

Comment 3

[Timothy Nikkel (:tnikkel)]

Can you still reproduce? I just tried and I couldn't.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Yes, looks like still happening on WebRender. I can no longer see the issue on non WebRender. I don't recall it was originally happening only on WebRender.

That said, it's hard to reproduce this, sometimes it happens, sometimes it doesn't happen at all..

Comment 5

[Hiroyuki Ikezoe (:hiro)]

It seems Session Restore is not related. I can see the issue with 1) open a new tab and 2) load https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API#Thresholds 3) scroll with dragging the scroll thumb.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Now I am suspecting this is also not related to IntersectionObserver. This looks somewhat related to interactions between the root scroller and the OOP iframe's scroller.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

I can reproduce on non WebRender as well. Probably the issue is easier reproducible on a debug build.

Comment 8

[Sean Voisen (:svoisen)]

Haven't been able to reproduce here. I'll set this to M7 (blocking Fission in beta) unless we find this happening in more scenarios.

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Attachment: A screencast

I tried local build to see whether it still persists or not, actually still there.

Comment 10

[Hiroyuki Ikezoe (:hiro)]

Confirmed still happening on a local debug build with/without WebRender.

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Note that I am now mostly sure that this issue is not related to session restore.

Comment 12

[Hiroyuki Ikezoe (:hiro)]

Attachment: A possible reduced test case

It seems like a key factor to reproduce this issue reliably is there should be a single browser window and single tab in the window. If there are multiple tabs, it's hard to reproduce (though I could sometimes reproduce it with multiple tabs).

And when the vertical scroll thumb is dragged, the scroll container's scroll amount is somewhat confused by the OOP iframe's scroll container?

Comment 13

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1613566 - Use layersId to find the target hit testing tree node for scroll thumb dragging. r?botond

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5b734ffc74f
Use layersId to find the target hit testing tree node for scroll thumb dragging. r=botond

Comment 15

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c5b734ffc74f