Closed Bug 1613603 Opened 1 year ago Closed 1 year ago

Add a localized alt attribute to the Interventions icon

Categories

(Firefox :: Address Bar, task, P1)

Product:
Firefox
Component:
Address Bar
Type:
task
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 74
Iteration:
74.2 - Jan 20 - Feb 09
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mak, Assigned: harry)

References

Details

(Keywords: access, Whiteboard: [access-p2])

Attachments

(1 file)

Bug 1613603 - Add a localized alt attribute to the Interventions icon. r?mak
47 bytes, text/x-phabricator-request
Details | Review

(James Teh [:Jamie] from https://bugzilla.mozilla.org/show_bug.cgi?id=1606921#c5)

Okay. I suggest giving the tip icon alt="tip:" (the colon is deliberate), giving it an id and then putting this before the title id in the aria-labelledby for the group:
https://searchfox.org/mozilla-central/rev/2e355fa82aaa87e8424a9927c8136be184eeb6c7/browser/components/urlbar/UrlbarView.jsm#1031
So we should end up with something like aria-labelledby="urlbarView-row-1-icon urlbarView-row-1-title".

Keywords: access
Whiteboard: [access-p2]
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 74.2 - Jan 20 - Feb 09
Blocks: 1613644
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9df518b41243
Add a localized alt attribute to the Interventions icon. r=mak,fluent-reviewers

https://hg.mozilla.org/mozilla-central/rev/9df518b41243

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in before you can comment on or make changes to this bug.