1613606 - PermissionMessageUtils.h: definition of implicit copy constructor for 'Principal' is deprecated because it has a user-declared copy assignment operator

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Just like bug 1605659 & bug 1603409:

In file included from /var/lib/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/ipc/ipdl/_ipdlheaders/mozilla/dom/PContent.h:25:
/var/lib/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/PermissionMessageUtils.h:30:14: error: definition of implicit copy constructor for 'Principal' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  Principal& operator=(const Principal& aOther) {
             ^
/var/lib/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/ipc/ipdl/_ipdlheaders/mozilla/dom/PContent.h:1857:9: note: in implicit copy constructor for 'IPC::Principal' first required here
        principal_(_principal),

Comment 1

[Sylvestre Ledru [:Sylvestre]]

With clang trunk and -Werror

Comment 2

[(Away)]

See bug 1515356 comment 9 for why this comes up despite the flag that disables it.

Comment 3

[(Away)]

Attachment: Use nsIPrincipal in BlobURLRegistrationData

clang-10 hits a -Werror in IPDL headers about Principal's copy constructor not being explicitly defined. We could go and fix that constructor, but in light of bug 1443956, I'm guessing it's not really a bad thing to have a discouragement against Principal when nsIPrincipal is now usable directly.

Comment 4

[(Away)]

Attachment: Bonus cleanup of IPC::Principals

All of these call sites were unnecessarily converting nsIPrincipal* => IPC::Principal => nsIPrincipal*.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f0b773f8c98
Use nsIPrincipal in BlobURLRegistrationData r=nika
https://hg.mozilla.org/integration/autoland/rev/73bdb73eb741
Bonus cleanup of IPC::Principals r=nika

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6f0b773f8c98
https://hg.mozilla.org/mozilla-central/rev/73bdb73eb741