1613621 - Glean Python pulls in too new version of Jinja, causing build failures

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P3)

Description

[Jan-Erik Rediger [:janerik]]

Our Python 3.5 tests are currently failing: https://circleci.com/gh/mozilla/glean/43476

ImportError while loading conftest '/home/circleci/project/glean-core/python/tests/conftest.py'.
glean-core/python/tests/conftest.py:14: in <module>
    from glean import testing
glean-core/python/.venv/lib/python3.5/site-packages/glean_sdk-24.1.0-py3.5-linux-x86_64.egg/glean/__init__.py:12: in <module>
    from ._loader import load_metrics, load_pings
glean-core/python/.venv/lib/python3.5/site-packages/glean_sdk-24.1.0-py3.5-linux-x86_64.egg/glean/_loader.py:20: in <module>
    from glean_parser.parser import parse_objects  # type: ignore
glean-core/python/.venv/lib/python3.5/site-packages/glean_parser-1.15.5-py3.5.egg/glean_parser/parser.py:19: in <module>
    from .metrics import Metric
glean-core/python/.venv/lib/python3.5/site-packages/glean_parser-1.15.5-py3.5.egg/glean_parser/metrics.py:14: in <module>
    from . import util
glean-core/python/.venv/lib/python3.5/site-packages/glean_parser-1.15.5-py3.5.egg/glean_parser/util.py:19: in <module>
    import jinja2
/home/circleci/project/glean-core/python/.venv/lib/python3.5/site-packages/Jinja2-3.0.0a1-py3.5.egg/jinja2/__init__.py:8: in <module>
    ???
E     File "/home/circleci/project/glean-core/python/.venv/lib/python3.5/site-packages/Jinja2-3.0.0a1-py3.5.egg/jinja2/bccache.py", line 207
E       dirname = f"_jinja2-cache-{os.getuid()}"
E                                              ^
E   SyntaxError: invalid syntax
make: *** [Makefile:63: test-python] Error 4

It's pulling in Jinja2-3.0.0a1.
Locally in my venv I have Jinja2-2.10.3 installed.

Looks like due to no proper dependency resolution (and version restrictions) it's pulling in a new major version that's incompatible with Python 3.5

given that I have no idea about Python's package management, I let mdboom handle this.

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: GitHub Pull Request

We issued a bug fix release after backporting the version restriction, which is already included in v1.17.3 anyway.