1613643 - Intermittent mingw /builds/worker/workspace/build/src/widget/windows/WindowsUIUtils.cpp:283:1: error: no template named 'Result'

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Treeherder Bug Filer]

Filed by: opoprus [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=287716426&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/TKpqMID9Tw2VmiVTh4JT3w/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-02-06T11:45:49.635Z] 11:45:49 ERROR - /builds/worker/workspace/build/src/widget/windows/WindowsUIUtils.cpp:283:1: error: no template named 'Result'
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - Result<HStringUniquePtr, HRESULT> ConvertToWindowsString(
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - ^
[task 2020-02-06T11:45:49.635Z] 11:45:49 ERROR - /builds/worker/workspace/build/src/widget/windows/WindowsUIUtils.cpp:289:12: error: use of undeclared identifier 'Err'; did you mean 'mozilla::Err'?
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - return Err(hr);
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - ^~~
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - mozilla::Err
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Result.h:526:30: note: 'mozilla::Err' declared here
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - inline GenericErrorResult<E> Err(E&& aErrorValue) {
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - ^
[task 2020-02-06T11:45:49.635Z] 11:45:49 ERROR - /builds/worker/workspace/build/src/widget/windows/WindowsUIUtils.cpp:289:12: error: no viable conversion from returned value of type 'GenericErrorResult<long &>' to function return type 'int'
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - return Err(hr);
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - ^~~~~~~
[task 2020-02-06T11:45:49.635Z] 11:45:49 ERROR - /builds/worker/workspace/build/src/widget/windows/WindowsUIUtils.cpp:291:10: error: no viable conversion from returned value of type 'HStringUniquePtr' (aka 'UniquePtr<HSTRING__ *, HStringDeleter>') to function return type 'int'
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - return HStringUniquePtr(rawStr);
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - ^~~~~~~~~~~~~~~~~~~~~~~~
[task 2020-02-06T11:45:49.635Z] 11:45:49 ERROR - /builds/worker/workspace/build/src/widget/windows/WindowsUIUtils.cpp:340:36: error: use of undeclared identifier 'MozPromiseHolder'
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - mozilla::media::Refcountable<MozPromiseHolder<SharePromise>>>();
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - ^
[task 2020-02-06T11:45:49.635Z] 11:45:49 ERROR - /builds/worker/workspace/build/src/widget/windows/WindowsUIUtils.cpp:340:36: error: use of undeclared identifier 'MozPromiseHolder'
[task 2020-02-06T11:45:49.635Z] 11:45:49 ERROR - /builds/worker/workspace/build/src/widget/windows/WindowsUIUtils.cpp:340:67: error: expected a type
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - mozilla::media::Refcountable<MozPromiseHolder<SharePromise>>>();
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - ^
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - 6 warnings and 7 errors generated.
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - /builds/worker/workspace/build/src/config/rules.mk:744: recipe for target 'WindowsUIUtils.o' failed
[task 2020-02-06T11:45:49.635Z] 11:45:49 ERROR - make[4]: *** [WindowsUIUtils.o] Error 1
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/widget/windows'
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - make[4]: *** Waiting for unfinished jobs....
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/layout/base'
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - layout/base/Unified_cpp_layout_base2.o
[task 2020-02-06T11:45:49.635Z] 11:45:49 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/layout/base'
[task 2020-02-06T11:45:52.268Z] 11:45:52 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/layout/forms'

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Can anybody of you fix this, please?

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Oops, working on it

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1613643 - Fix build failure by Result<>

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ae6d4566639
Fix build failure by Result<>

Comment 5

[Oana Pop-Rus]

The issue is still present: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=0ae6d45666391c9faa8504af7fea808eb934dfdb&selectedJob=287738317

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1613643 - Fix build failure by Err()

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/442f57db73ea
Fix build failure by Err(). a=bustage-fix-for-mingw CLOSED TREE

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0ae6d4566639
https://hg.mozilla.org/mozilla-central/rev/442f57db73ea

Comment 9

[Intermittent Failures Robot]

46 failures in 761 pushes (0.06 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 46

Platform breakdown:

• windows-mingw32: 46

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1613643&startday=2020-02-06&endday=2020-02-06&tree=all

Comment 10

[Intermittent Failures Robot]

50 failures in 3364 pushes (0.015 failures/push) were associated with this bug in the last 7 days.

This is the #6 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 46
• try: 4

Platform breakdown:

• windows-mingw32: 50

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1613643&startday=2020-02-03&endday=2020-02-09&tree=all

Comment 11

[Intermittent Failures Robot]

4 failures in 4690 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 4

Platform breakdown:

• windows-mingw32: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1613643&startday=2020-02-10&endday=2020-02-16&tree=all