Closed
Bug 1613644
Opened 4 years ago
Closed 4 years ago
_updateIndices shouldn't have to change ids
Categories
(Firefox :: Address Bar, task, P3)
Firefox
Address Bar
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: perf)
Attachments
(1 file)
The scope for _updateIndices was to update the .rowIndex value of a result, but it also started setting up unique ids based on the index value and from that it sets the aria label and other "unique" ids... And it does it for each row.
it should not be necessary to do all of this, we can generate a unique id when we create the row, that doesn't depend on the index of the row.
And we can store rowIndex in an attribute for cases like https://searchfox.org/mozilla-central/search?q=%23urlbarView-row-&case=false®exp=false&path=
|
Assignee | |
Updated•4 years ago
|
Points: --- → 1
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/80a35f1cb027 UrlbarView::_updateIndices() shouldn't have to change ids with row indices. r=dao
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
You need to log in
before you can comment on or make changes to this bug.
Description
•