1613676 - Master Password prompt appears on a new tab after restart.

Status: RESOLVED DUPLICATE of bug 1608347

(Core :: DOM: Navigation, defect, P3)

Description

[Pablo]

Affected versions
Nightly 74.0a1
Release 72.0.2
Beta 73

Affected platforms
Windows 10 64x
Ubuntu 18.04 64x
macOS 10.14

Steps to reproduce:

Open Firefox
Go to hamburger menu > Options > privacy and security
Click "use master password" and set a password
Open new tab and login to any gmail account
Close all tabs, leave a tab open with another site, example duckduckgo.com
Close browser and launch again firefox.

Actual result:
Firefox restarts and master password modal appears on blank new tab.

Expected result:
Master password modal should not appear on a new tab.

Additional notes:
Because gmail appears on new tab "Top Sites", it kicks the master password prompt with firefox only having 1 tab ( a new tab).
(the idea of the bug is to have master password set and a login saved like gmail, and gmail to appear on top sites section on a new tab, having only 1 tab that is just a normal default new tab)

Sometimes after restart you need to scroll down a little for the prompt to appear, on linux it shows up after restart without any scrolling.

I was not able to reproduce this when i set signon.debug to true in about:Config tho, master password prompt was not showing up.

Comment 1

[Pablo]

Attachment: record.mp4

Comment 2

[Alice0775 White]

Probably this is duplication of Bug 1608347

Comment 3

[Adrian Florinescu [:aflorinescu]]

Yes, this is a dupe. Thanks Alice0775!

Comment 4

[abodenlosz]

Regression range

• First bad: 15a9ec5f9b344d37cc7c1b6144e0d22adc365272

• Last good: fa1d78394a9664472d2f5a394af5f3133f2f9995

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fa1d78394a9664472d2f5a394af5f3133f2f9995&tochange=15a9ec5f9b344d37cc7c1b6144e0d22adc365272

• It seems that Bug 1579992 has caused the regression.

Comment 5

[Alice0775 White]

According to comment #4

This seems not duplication of Bug 1608347.
REOPENED.

Comment 6

[Alice0775 White]

(In reply to abodenlosz from comment #4)

Regression range

• First bad: 15a9ec5f9b344d37cc7c1b6144e0d22adc365272

• Last good: fa1d78394a9664472d2f5a394af5f3133f2f9995

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fa1d78394a9664472d2f5a394af5f3133f2f9995&tochange=15a9ec5f9b344d37cc7c1b6144e0d22adc365272

• It seems that Bug 1579992 has caused the regression.

Well let's see, even with a good build I can reproduce the problem ...

Comment 7

[Adrian Florinescu [:aflorinescu]]

From the STR point of view bug 1608347 and this one are similar enough to be dupes.

Regarding the regression range, I get mixed results and unconclusive ones. There are some instances in which the bug stops reproducing. (in comment 0 - reportedly when enabling signon.debug, but trying several mozregression runs, seems like there are other factors that stop the bug reproducing - haven't figured out any root cause for those).

A wide regression range that can be manually confirmed is 10.20 - 10.25 (most of my mozregressions tries idenfied it somehwere betwen 22-23).

@Valentin, do you think this regression can be something introduced by bug 1579992 ?

Comment 8

[Valentin Gosu [:valentin] (he/him)]

(In reply to Adrian Florinescu [:aflorinescu] from comment #7)

@Valentin, do you think this regression can be something introduced by bug 1579992 ?

I don't know enough about how the password manager works to say if bug 1579992 is actually the cause of this.
The question is if the fix for bug 1608347 also fixes this.

Comment 9

[Adrian Florinescu [:aflorinescu]]

(In reply to Valentin Gosu [:valentin] (he/him) from comment #8)

(In reply to Adrian Florinescu [:aflorinescu] from comment #7)

@Valentin, do you think this regression can be something introduced by bug 1579992 ?

I don't know enough about how the password manager works to say if bug 1579992 is actually the cause of this.
The question is if the fix for bug 1608347 also fixes this.

Fair enough. I see Neal is working on bug 1608347, then let's depend further investigation on bug 1608347, then decide on further action based on that testing result.

Note:
Adding dependency on bug 1608347 based on the above rationale.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Neil, does you patch fix this one too? Or is this even a dup?

Comment 11

[Neil Deakin]

It sure looks like a duplicate of 1608347. Of particular note in the video, you can see that the gmail thumbnail has not yet loaded when the master password prompt appears.

Note that reproducing the bug depends on if there is time to load the thumbnail before quitting and whether it is already cached.

Comment 12

[Daniel Bodea [:danibodea]]

William, Can you please have an opinion on this situation? My issue is that the steps to reproduce include a session restart and I can't do that using mozregression and keep my cache. Do you know of a way I could do that with mozregression?

Or do you know of a way I could find this bug's regressor? Thank you.

Comment 13

[William Lachance (:wlach)]

(In reply to Bodea Daniel [:danibodea] from comment #12)

William, Can you please have an opinion on this situation? My issue is that the steps to reproduce include a session restart and I can't do that using mozregression and keep my cache. Do you know of a way I could do that with mozregression?

Or do you know of a way I could find this bug's regressor? Thank you.

You should be able to relaunch a copy of Firefox downloaded by mozregression before proceeding with bisection. Just copy and paste the application command before answering whether the build was good or bad. e.g.:

 3:18.90 INFO: Running mozilla-central build for 2020-03-10
 3:36.22 INFO: Launching /private/var/folders/gx/f2n3817j0b5gg6pfxv6p0t6r0000gn/T/tmp_212ty5p/Firefox Nightly.app/Contents/MacOS/firefox
 3:36.22 INFO: Application command: /private/var/folders/gx/f2n3817j0b5gg6pfxv6p0t6r0000gn/T/tmp_212ty5p/Firefox Nightly.app/Contents/MacOS/firefox --allow-downgrade -foreground -profile /var/folders/gx/f2n3817j0b5gg6pfxv6p0t6r0000gn/T/tmp0e_oxlx_.mozrunner
 3:36.53 INFO: application_buildid: 20200310214454
 3:36.53 INFO: application_changeset: a7a6063bd5a4b49911b5a956c252a16961aec5a0
 3:36.53 INFO: application_name: Firefox
 3:36.53 INFO: application_repository: https://hg.mozilla.org/mozilla-central
 3:36.53 INFO: application_version: 76.0a1
Was this nightly build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry' or 'exit' and press Enter): 

Just re-run the application command from a console (you may need to quote parts of it) e.g.

"/private/var/folders/gx/f2n3817j0b5gg6pfxv6p0t6r0000gn/T/tmp_212ty5p/Firefox Nightly.app/Contents/MacOS/firefox" --allow-downgrade -foreground -profile /var/folders/gx/f2n3817j0b5gg6pfxv6p0t6r0000gn/T/tmp0e_oxlx_.mozrunner

Changes between sessions should be persisted.

Comment 14

[Daniel Bodea [:danibodea]]

Hey, Pablo, can you still reproduce this in latest Nightly? I couldn't.

Comment 15

[Pablo]

Hi daniel

I tried to reproduce on Firefox latest nightly 76.0a1 and i can´t replicate the issue anymore.

Tested with:

Windows 10 64bit
Ubuntu 18.04 64bit
MacOS 10.14

it looks fixed on all 3 of them