1613722 - SanitizeOnShutdown should allow unset values and unlocked

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement, P3)

Description

[Mike Kaply [:mkaply]]

Currently the SanitizeOnShutdown policy always sets undefined values to false.

It should not. It should ignore unset values.

In addition, it should allow the values to be locked or unlocked.

Comment 1

[Mike Kaply [:mkaply]]

I remember why I did it this way. Many of the sanitize values default to true. So if you just flip privacy.sanitize.sanitizeOnShutdown, lots of things will get cleared by default.

I think just adding the ability to not lock the prefs is enough (and fix the GPO so you can choose to not define things)

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 1613722 - Allow sanitize policy to be unlocked. r?mconley

Comment 3

[Mike Kaply [:mkaply]]

This is what I should have done initially. Allow locking and only lock explicit values. And flip the true values to false so that setting sanitizeonshutdown doesn't delete everything when you set one thing.

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Bug 1613722 - Allow sanitize policy to be unlocked. r?mconley

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c320249e8fcb
Allow sanitize policy to be unlocked. r=mconley

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c320249e8fcb

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 9126240 [details]
Bug 1613722 - Allow sanitize policy to be unlocked. r?mconley

Beta/Release Uplift Approval Request

• User impact if declined: SanitizeOnShutdown policy can't be unlocked, a little clunky
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only. Automated test, existing behavior unchanged.
• String changes made/needed:

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy, customer requested feature.
• User impact if declined: SanitizeOnShutdown policy can't be unlocked, a little clunky
• Fix Landed on Version: 75
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only. Automated test, existing behavior unchanged.
• String or UUID changes made by this patch:

Comment 8

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Comment on attachment 9126240 [details]
Bug 1613722 - Allow sanitize policy to be unlocked. r?mconley

Looks safe for beta, uplift approved for 74.0b6, thanks.

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c487d7f3ebff

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9126240 [details]
Bug 1613722 - Allow sanitize policy to be unlocked. r?mconley

Policy engine update, approved for 68.6esr.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/22ccac018b29