1613733 - Set toolkit.shutdown.fastShutdownStage to 1 (ShutdownPostLastCycleCollection) on Nightly

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Alex Thayer [:alexical] (she/her)]

Now that the pref has landed, I'm filing this to track turning it on to its first setting after "off", which is to shutdown via _exit(0) immediately after the last cycle collection.

I feel reasonably confident in this, because we see no late write telemetry coming in after that point, but it should nevertheless wait until after the current code freeze. I will be dogfooding it in the mean time.

Comment 1

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1613733 - Enable fast shutdown at last cycle collection r?froydnj

I think this is ready. We see no late write checks coming in from this
period in telemetry, and it's early in the cycle, so I think the best
time to enable this is now.

Comment 2

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1613733 - Enable fast shutdown at last cycle collection r?froydnj

I think this is ready. We see no late write checks coming in from this
period in telemetry, and it's early in the cycle, so I think the best
time to enable this is now.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19c9be9294f4
Enable fast shutdown at last cycle collection r=froydnj

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7172b32a80d
Backed out changeset 19c9be9294f4 for Android Bpgo build bustages. CLOSED TREE

Comment 5

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 19c9be9294f4 (Bug 1613733) for Android Bpgo build bustages.
https://hg.mozilla.org/integration/autoland/rev/c7172b32a80d6ec2be386c60d48f42b4dbbcf5a6

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=49925756d93c58d30059a8e8b67c0fe9921c9844&selectedJob=288812417

https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=Android%2C4.0%2CAPI16%2B%2Cpgo%2CProfile-guided%2Coptimization%2Cbuilds%2Cgenerate-profile-android-api-16%2Fpgo%2CBpgo%28run%29&tochange=c7172b32a80d6ec2be386c60d48f42b4dbbcf5a6&fromchange=19c9be9294f4a813cd5e6224e094e1ac42c60139

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288812417&repo=autoland&lineNumber=1587

Comment 6

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #24938 (as of Fri, 14 Feb 2020 08:46:22 GMT) ==

Regressions:

1% installer size osx-shippable opt nightly 79,672,729.17 -> 80,405,005.75

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24938

Comment 7

[Alex Thayer [:alexical] (she/her)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2870dc7e78d9c36dc726e0dd7e338bbfcc770193

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c436ac31df8
Enable fast shutdown at last cycle collection r=froydnj

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/8c436ac31df8