1613739 - Ensure we can switch layouts from 1 row to 7 via pref

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Scott [:thecount] Downe]

This is specifically for DE, which is 1 row right now because of lack of content.

We're getting more content specifically for DE and want to be able to test that, so we need to ensure that pref works.

Right now it's browser.newtabpage.activity-stream.discoverystream.lang-layout-config

It's lang based, which is kinda awkward, because we cannot specifically target GB, as an example.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1613739 - Pref to switch story rows based on region

Comment 2

[Scott [:thecount] Downe]

We can technically do this now for DE using a pref.

To do this, ensure you have a de browser, and set browser.newtabpage.activity-stream.discoverystream.lang-layout-config from "en" to "en,de"

The bug I have attached to this modifies this from lang based, to region based, so we can specifically target UK separately from US if we want to.

Example, the above pref would move to browser.newtabpage.activity-stream.discoverystream.region-layout-config and the value would change from "en" to "US,CA"

Comment 3

[Scott [:thecount] Downe]

To test:

1. Using an en-US or en-CA browser

2. with matching browser.search.region value (US or CA).
   Expected: 7 rows of stories

3. Change browser.newtabpage.activity-stream.discoverystream.region-layout-config to "DE"

4. restart the browser
   Expected: 1 row of stories.

5. Using a de browser.

6. with matching browser.search.region value (DE).
   Expected: 1 row of stories.

7. Using a de browser.

8. with matching browser.search.region value (DE).

9. Set browser.newtabpage.activity-stream.discoverystream.region-layout-config to "DE"

10. restart the browser
    Expected: 7 rows of stories

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25089cefb258
Pref to switch story rows based on region r=gvn

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/25089cefb258

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified the following using the steps provided by Scott in comment 3:

• 7 rows of stories are displayed for Firefox Nightly "en-US" or "en-CA" locale builds with the "browser.search.region" pref set to "US" or "CA";
• 1 row of stories is displayed for Firefox Nightly "en-US" or "en-CA" locale builds with the "browser.newtabpage.activity-stream.discoverystream.region-layout-config" pref set to "DE";
• 1 row of stories is displayed for Firefox Nightly "DE" locale build with the "browser.search.region" pref set to "DE";
• 7 rows of stories are displayed for Firefox Nightly "DE" locale build with the "browser.search.region" and the "browser.newtabpage.activity-stream.discoverystream.region-layout-config" prefs set to "DE";

Verified using the latest Firefox Nightly (75.0a1 Build ID - 20200225214332) "en-US", "en-CA" and "de" locale builds installed on Windows 10 x64, Mac 10.15.2, and Ubuntu 18.04 x64.