Closed Bug 1613789 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 21646 - Fix round(), abstract the tests

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21646 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21646
Details from upstream follow.

Tab Atkins-Bittner <jackalmage@gmail.com> wrote:

Fix round(), abstract the tests

Fix the rounding tests due to changes in the spec, and generally abstract the testing framework in preparation more math function tests using them.

PR 21646 applied with additional changes from upstream: 5c5f1c18f51f5774b67cfd6672b88dae3fa8af25
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 44 tests

Status Summary

Firefox

OK : 1
PASS: 43
FAIL: 66

Chrome

OK : 1
FAIL: 66

Safari

OK : 1
FAIL: 66

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-values/round-function.html
round(15px, -10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(nearest, 15px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(nearest, 13px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px / round(-5, infinity)) should be used-value-equivalent to calc(-infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px / round(-5, -infinity)) should be used-value-equivalent to calc(-infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px / round(up, 0, infinity)) should be used-value-equivalent to calc(infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px / round(5, -infinity)) should be used-value-equivalent to calc(infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
round(down, 18px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(-18px, 10px) should be used-value-equivalent to -20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(up, 18px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px * round(-infinity, infinity)) should be used-value-equivalent to calc(NaN * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
round(15px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(down, 13px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px * round(5, 0)) should be used-value-equivalent to calc(NaN * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px * round(infinity, 5)) should be used-value-equivalent to calc(infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px * round(infinity, -infinity)) should be used-value-equivalent to calc(NaN * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
round(23px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(13px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(down, -13px, 10px) should be used-value-equivalent to -20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(13px, -10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px / round(to-zero, -5, -infinity)) should be used-value-equivalent to calc(-infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px / round(5, infinity)) should be used-value-equivalent to calc(infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(-1px * round(5, 0)) should be used-value-equivalent to calc(NaN * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
round(to-zero, 23px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px * round(-infinity, 5)) should be used-value-equivalent to calc(-infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
round(down, 15px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(up, -13px, 10px) should be used-value-equivalent to -10px: FAIL (Chrome: FAIL, Safari: FAIL)
calc(-1px * round(-infinity, infinity)) should be used-value-equivalent to calc(NaN * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
round(to-zero, 13px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(down, -18px, 10px) should be used-value-equivalent to -20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(up, -18px, 10px) should be used-value-equivalent to -10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(to-zero, -13px, 10px) should be used-value-equivalent to -10px: FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px * round(-infinity, -5)) should be used-value-equivalent to calc(-infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
round(18px, -10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(18px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px * round(-infinity, -infinity)) should be used-value-equivalent to calc(NaN * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px / round(to-zero, 5, infinity)) should be used-value-equivalent to calc(infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px / round(down, 1, infinity)) should be used-value-equivalent to calc(infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
round(up, 15px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(23px, -10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(nearest, 23px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px / round(to-zero, 5, -infinity)) should be used-value-equivalent to calc(infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px / round(up, -1 * 0, infinity) should be used-value-equivalent to calc(-infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px * round(down, -1, infinity)) should be used-value-equivalent to calc(-infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px / round(down, -1 * 0, infinity)) should be used-value-equivalent to calc(-infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
round(up, 13px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(nearest, -18px, 10px) should be used-value-equivalent to -20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(down, 23px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(-13px, 10px) should be used-value-equivalent to -10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(nearest, 18px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
calc(-1px * round(-infinity, -infinity)) should be used-value-equivalent to calc(NaN * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
round(to-zero, 18px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(-13px, -10px) should be used-value-equivalent to -10px: FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px / round(to-zero, -5, infinity)) should be used-value-equivalent to calc(-infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px * round(up, 1, infinity)) should be used-value-equivalent to calc(infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(-1px * round(infinity, -infinity)) should be used-value-equivalent to calc(NaN * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
round(to-zero, 15px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
calc(-1px * round(infinity, infinity)) should be used-value-equivalent to calc(NaN * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px * round(infinity, -5)) should be used-value-equivalent to calc(infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
round(nearest, -13px, 10px) should be used-value-equivalent to -10px: FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px / round(down, 0, infinity)) should be used-value-equivalent to calc(infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
round(-18px, -10px) should be used-value-equivalent to -20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(up, 23px, 10px) should be used-value-equivalent to 30px: FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px / round(up, -1, infinity) should be used-value-equivalent to calc(-infinity * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
calc(1px * round(infinity, infinity)) should be used-value-equivalent to calc(NaN * 1px): FAIL (Chrome: FAIL, Safari: FAIL)
round(to-zero, -18px, 10px) should be used-value-equivalent to -10px: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/35465641fa98 [wpt PR 21646] - Fix round(), abstract the tests, a=testonly https://hg.mozilla.org/integration/autoland/rev/b5c7d6934e83 [wpt PR 21646] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/35465641fa98
https://hg.mozilla.org/mozilla-central/rev/b5c7d6934e83

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.