Closed
Bug 161379
Opened 22 years ago
Closed 22 years ago
Fix JavaScript warnings in security code
Categories
(Core Graveyard :: Security: UI, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: KaiE, Assigned: KaiE)
Details
Attachments
(1 file)
2.45 KB,
patch
|
ssaux
:
review+
mscott
:
superreview+
|
Details | Diff | Splinter Review |
Fix JavaScript warnings in security code WARNING: waaah!, file /home/kaie/trunk/mozilla/content/xul/document/src/nsXULPrototypeDocument.cpp, line 782 JavaScript strict warning: chrome://messenger/content/am-smime.js line 219: function checkOtherCert does not always return a value WARNING: waaah!, file /home/kaie/trunk/mozilla/content/xul/document/src/nsXULPrototypeDocument.cpp, line 782 JavaScript strict warning: chrome://messenger/content/am-smime.js line 228: function checkOtherCert does not always return a value WARNING: waaah!, file /home/kaie/trunk/mozilla/content/xul/document/src/nsXULPrototypeDocument.cpp, line 782 JavaScript strict warning: chrome://messenger/content/am-smime.js line 252: function checkOtherCert does not always return a value JavaScript strict warning: chrome://messenger/content/am-smime.js line 148: assignment to undeclared variable i CSS Error (chrome://pippki/content/clientauthask.xul :1.20): Expected ':' but found '='. Declaration dropped. JavaScript strict warning: chrome://pippki/content/clientauthask.js line 71: assignment to undeclared variable details Actually, let's remove the width style in the client auth dialog. It has obviously never worked, because if I fix the = with a :, the dialog is way too large. The automatic width sizing seems to work just fine.
Assignee | ||
Comment 1•22 years ago
|
||
Assignee | ||
Comment 2•22 years ago
|
||
Javi or Stephane, can you please review this small patch?
Comment 3•22 years ago
|
||
Comment on attachment 94251 [details] [diff] [review] Patch v1 r=ssaux
Attachment #94251 -
Flags: review+
Comment 4•22 years ago
|
||
Comment on attachment 94251 [details] [diff] [review] Patch v1 sr=mscott
Attachment #94251 -
Flags: superreview+
Assignee | ||
Comment 5•22 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•