1613801 - macOS' Window menu has the brand-full-name suffix repeated at the end of every browser window title

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P1)

Description

[Matthew N. [:MattN]]

Attachment: "- Firefox Nightly" suffix shown for every window

Every window listed in the macOS "Window" menu now duplicates the -brand-full-name causing the menu items to be longer and more noisy.

Last good revision: eb874118621070fa4ef69cb951b2dd7a51f93d66
First bad revision: bff9eef8191f12cee9af275966a563517dcdf429
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=eb874118621070fa4ef69cb951b2dd7a51f93d66&tochange=bff9eef8191f12cee9af275966a563517dcdf429

From skimming bug 1591328 and the Phabricator reviews I don't think this was intentional, or was it?

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Looking at browser-main-window-content-title it seems like an intended outcome.

Gijs - is that something worse reconsidering?

Comment 2

[:Gijs (he/him)]

(In reply to Zibi Braniecki [:zbraniecki][:gandalf] from comment #1)

Looking at browser-main-window-content-title it seems like an intended outcome.

Gijs - is that something worse reconsidering?

I don't really understand; the macOS window menu prior to the changes didn't have the suffix (I just checked), and now it does. That doesn't seem like an intended outcome to me, just something that got missed when reviewing...

Looking into it, it seems this is because although the titlemodifier was set to the brand name by default, it wasn't on macOS, cf. https://searchfox.org/mozilla-esr68/rev/bbc55d9f112cc053352a979463fc3ae2b516e1a9/browser/base/content/browser.xul#47-58 .

I expect the FTL here need a check for macOS and should omit the brandname in that case.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

I don't really understand; the macOS window menu prior to the changes didn't have the suffix (I just checked), and now it does. That doesn't seem like an intended outcome to me, just something that got missed when reviewing...

Ah, then it's my fault. I noticed that outcome out of our brainstorm in the original migration bug and assumed that you're suggesting intentional coalescing of behaviors (prior to the migration there was a high number of permutations possible).

I expect the FTL here need a check for macOS and should omit the brandname in that case.

Gotcha, yep.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1613801 - Don't include brand name in the window title on Mac.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5c72e92c4dc
Don't include brand name in the window title on Mac. r=fluent-reviewers,flod,Gijs

Comment 6

[Stefan Hindli [:stefan_hindli]]

Backed out changeset e5c72e92c4dc (Bug 1613801) for causing bc permafailures in browser_privatebrowsing_windowtitle.js CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=289283286

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289283286&repo=autoland&lineNumber=6388

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5df075b6a6bb
Backed out changeset e5c72e92c4dc for causing bc permafailures in browser_privatebrowsing_windowtitle.js  CLOSED TREE

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1615907-searchBox-focus.patch

Yes sorry, was too enthusiastic to change all. Now this works with all searchboxes. I fixed also that focus has precedence to hover.

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 9127205 [details] [diff] [review]
1615907-searchBox-focus.patch

Sorry wrong bug.

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thank you! Had to update a single test to expect different title between Mac and others.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/021e98de289d
Don't include brand name in the window title on Mac. r=fluent-reviewers,flod,Gijs

Comment 12

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/021e98de289d

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 14

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 9125728 [details]
Bug 1613801 - Don't include brand name in the window title on Mac.

Beta/Release Uplift Approval Request

• User impact if declined: Unnecessary product name in a list of windows on MacOS.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed: browser-main-window-content-title-default, browser-main-window-content-title-private

Comment 15

[Francesco Lodolo [:flod]]

(In reply to Zibi Braniecki [:zbraniecki][:gandalf] from comment #14)

• String changes made/needed: browser-main-window-content-title-default, browser-main-window-content-title-private

Just to confirm, it's OK to uplift this.

Comment 16

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9125728 [details]
Bug 1613801 - Don't include brand name in the window title on Mac.

Looks safe, uplift approved for 74.0b8, thanks.

Comment 17

[Razvan Maries]

https://hg.mozilla.org/releases/mozilla-beta/rev/5436d386d503