1613804 - InputConnection.finishComposingText should commit composition text

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Makoto Kato [:m_kato]]

STEP

1. Set GBoard as default keyboard with US
2. Browse any site that has text box. ex. https://www.google.com
3. Input "@"

RESULT

"@" is composing state

EXPECTED RESULT

"@" isn't composing state like Google Chrome.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1613804 - InputConnection.finishComposingText should commit composition text.

Gecko don't commit composition when software keyboard calls
InputConnection.finishComposingText. It is incompatible with Blink's behaviour.

BaseInputConnection.finishComposingText() implementation is the following.

1. Begin batch edit.
2. Remove all composition span flag.
3. End batch edit.

So if no composition after batch edit is finished, we should commit it on Gecko
to synchronize composition state.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0232994602b7
InputConnection.finishComposingText should commit composition text. r=geckoview-reviewers,snorp

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/0232994602b7