Closed Bug 161383 Opened 21 years ago Closed 20 years ago

Checkmark indicating active window in Window menu only shows on second menu access


(Core :: XUL, defect)

Not set





(Reporter: bugmail, Assigned: macrxnapa)


(Blocks 1 open bug)


(Keywords: fixed1.7)


(1 file)

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.1b) Gecko/20020805
BuildID:    2002080508

The checkmark that's supposed to display in front of the name of the active
window in the Window menu doesn't display until the second time the menu is

Reproducible: Always
Steps to Reproduce:
1. Launch Mozilla to display one Navigator window
2. Access the Window menu

Actual Results:  The checkmark is not displayed in front of window 1's listing
on the Window menu.

Expected Results:  The checkmark should have been displayed in front of window
1's listing on the Window menu.

The checkmark displays the second time the Window menu is accessed.
Bug 144622 may be caused by the same underlying problem.
Blocks: 90824
I'm also using Moz 1.5 RC2 on OS X and find times when 4 out of 5 windows have
the checkmark in front of them in the Window menu.

checkmarks appear without rhyme or reason.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5) Gecko/20030925
changing onpopupshown to onpopupshowing solves the menu upadate problem in my

Patch forthcoming.

Reassigning to patch author.
Assignee: hyatt → macdoc
Comment on attachment 140356 [details] [diff] [review]
changes onpopupshown to onpopupshowing

Adding review?
Attachment #140356 - Flags: review?(hyatt)
Requesting blocking1.7. Has patch needing review.
Flags: blocking1.7?
Simon or pink, might one of you be able to review this patch?
this impacts both seamonkey and firefox (and probably thunderbird as well).
Bryner, can you take a look at this patch? It looks trivial to my untrained eye. 
Attachment #140356 - Flags: review?(hyatt) → review?(
Comment on attachment 140356 [details] [diff] [review]
changes onpopupshown to onpopupshowing

Looks like the mac native menu is built in between the popupshowing and
popupshown event so that no changes in the popupshown event will take effect.
Attachment #140356 - Flags: review?( → review+
Attachment #140356 - Flags: superreview?(roc)
Attachment #140356 - Flags: superreview?(roc) → superreview+
Comment on attachment 140356 [details] [diff] [review]
changes onpopupshown to onpopupshowing

a=asa (on behalf of drivers) for checkin to 1.7
Attachment #140356 - Flags: approval1.7+
Flags: blocking1.7? → blocking1.7+
Just confirming that this now works with a CVS HEAD build.
Keywords: fixed1.7
Why is this bug still open?
Who checked this in? roc? neil?
Yes, I checked it in 9 days ago, sorry for not resolving this bug.
Closed: 20 years ago
Resolution: --- → FIXED
Blocks: 269644
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.