1613833 - PeriodicWave constructor does not allow zero-length real and imag

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

Consider this testcase:

var ctx = new AudioContext()
new PeriodicWave(ctx, { real: [], imag: [] })

In Firefox this throws. In Chrome it does not (though I don't know what the slots end up storing in that case; there's no obvious way to inspect them). Per spec it should not throw, I think, though the spec is confused enough around this stuff that who knows...

Is this a bug in Firefox or a bug in Chrome and the spec?

Comment 1

[Karl Tomlinson (:karlt)]

https://github.com/WebAudio/web-audio-api/pull/2168/files added some IndexSizeErrors for lengths less than 2.

Comment 2

[Boris Zbarsky [:bzbarsky]]

OK. We should add tests for that... Ideally that would have happened as part of the spec change.

Comment 3

[carnould]

Attachment: Bug 1613833 - Changed length condition to suit the spec. r?padenot

Throws are now centralized too.

Comment 4

[carnould]

Attachment: Bug 1613833 - Updated mochitest. r?padenot

Depends on D84665

Comment 5

[carnould]

Attachment: Bug 1613833 - Added wpt. r?padenot

Depends on D84666

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60d22caf219b
Changed length condition to suit the spec. r=padenot
https://hg.mozilla.org/integration/autoland/rev/2688c7fb493a
Updated mochitest. r=padenot
https://hg.mozilla.org/integration/autoland/rev/a93c24810dce
Added wpt. r=padenot

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24828 for changes under testing/web-platform/tests

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/60d22caf219b
https://hg.mozilla.org/mozilla-central/rev/2688c7fb493a
https://hg.mozilla.org/mozilla-central/rev/a93c24810dce

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot