Closed Bug 1613862 Opened 6 years ago Closed 5 years ago

Intermittent dom/security/test/general/test_block_toplevel_data_navigation.html | uncaught exception - NS_ERROR_XPC_SECURITY_MANAGER_VETO: at test3/<@http://mochi.test:8888/tests/dom/security/test/general/test_block_toplevel_data_navigation.html:72:10

Categories

(Core :: DOM: Security, defect, P5)

defect

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: intermittent-bug-filer, Assigned: kmag)

References

Details

(Keywords: intermittent-failure, Whiteboard: [domsecurity-intermittent])

Filed by: ccoroiu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=287891541&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Nh9wQsl1R9GkKJUOujZY6Q/runs/0/artifacts/public/logs/live_backing.log


[task 2020-02-07T09:01:17.418Z] 09:01:17 INFO - TEST-PASS | dom/security/test/general/test_block_toplevel_data_navigation.html | data: URI navigation through win.loc.href should be blocked
[task 2020-02-07T09:01:17.419Z] 09:01:17 INFO - Buffered messages finished
[task 2020-02-07T09:01:17.420Z] 09:01:17 INFO - TEST-UNEXPECTED-FAIL | dom/security/test/general/test_block_toplevel_data_navigation.html | uncaught exception - NS_ERROR_XPC_SECURITY_MANAGER_VETO: at test3/<@http://mochi.test:8888/tests/dom/security/test/general/test_block_toplevel_data_navigation.html:72:10
[task 2020-02-07T09:01:17.421Z] 09:01:17 INFO - setTimeout handlerSimpleTest_setTimeoutShim@http://mochi.test:8888/tests/SimpleTest/SimpleTest.js:689:43
[task 2020-02-07T09:01:17.422Z] 09:01:17 INFO - test3@http://mochi.test:8888/tests/dom/security/test/general/test_block_toplevel_data_navigation.html:69:13
[task 2020-02-07T09:01:17.423Z] 09:01:17 INFO - receiveMessage@http://mochi.test:8888/tests/dom/security/test/general/test_block_toplevel_data_navigation.html:61:5
[task 2020-02-07T09:01:17.424Z] 09:01:17 INFO - EventListener.handleEvent
test2@http://mochi.test:8888/tests/dom/security/test/general/test_block_toplevel_data_navigation.html:55:10
[task 2020-02-07T09:01:17.425Z] 09:01:17 INFO - test1/<@http://mochi.test:8888/tests/dom/security/test/general/test_block_toplevel_data_navigation.html:48:5
[task 2020-02-07T09:01:17.426Z] 09:01:17 INFO - setTimeout handlerSimpleTest_setTimeoutShim@http://mochi.test:8888/tests/SimpleTest/SimpleTest.js:689:43
[task 2020-02-07T09:01:17.427Z] 09:01:17 INFO - test1@http://mochi.test:8888/tests/dom/security/test/general/test_block_toplevel_data_navigation.html:44:13
[task 2020-02-07T09:01:17.428Z] 09:01:17 INFO - @http://mochi.test:8888/tests/dom/security/test/general/test_block_toplevel_data_navigation.html:103:1
[task 2020-02-07T09:01:17.429Z] 09:01:17 INFO -
[task 2020-02-07T09:01:17.429Z] 09:01:17 INFO - simpletestOnerror@SimpleTest/SimpleTest.js:1696:24
[task 2020-02-07T09:01:17.430Z] 09:01:17 INFO - OnErrorEventHandlerNonNull
@SimpleTest/SimpleTest.js:1676:1
[task 2020-02-07T09:01:17.431Z] 09:01:17 INFO - GECKO(2412) | JavaScript error: http://mochi.test:8888/tests/dom/security/test/general/test_block_toplevel_data_navigation.html, line 72: NS_ERROR_XPC_SECURITY_MANAGER_VETO:
[task 2020-02-07T09:01:17.432Z] 09:01:17 INFO - GECKO(2412) | MEMORY STAT | vsize 2583MB | residentFast 161MB | heapAllocated 17MB

Is this a regression from bug 1557739?

Flags: needinfo?(nika)
Whiteboard: [domsecurity-intermittent]

I'm not sure how that particular patch could be impacting this, as it doesn't touch anything which should be close to this issue. There's probably another change which caused this to start happening. I think this is most likely to be caused by bug 1582832, as it touched BrowsingContext discarding, and landed around the same time.

The line which threw is win3.close(), here: https://searchfox.org/mozilla-central/rev/623de665034eee43a54ff02939b61385ffd5990d/dom/security/test/general/test_block_toplevel_data_navigation.html#72. It's throwing a NS_ERROR_XPC_SECURITY_MANAGER_VETO, which appears to be being caused by https://searchfox.org/mozilla-central/rev/623de665034eee43a54ff02939b61385ffd5990d/dom/base/nsGlobalWindowInner.cpp#295.

This implies that we're in a situation where win3's BrowsingContext has been discarded, but the inner/outer window link hasn't yet been broken. In particular, mOuterWindow is non-null, but IsCurrentInnerWindow is false. This could potentially be caused by our BrowsingContext becoming discarded before the inner/outer window link is broken.

Flags: needinfo?(nika) → needinfo?(kmaglione+bmo)
Assignee: nobody → kmaglione+bmo
Depends on: 1614259
Flags: needinfo?(kmaglione+bmo)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.