1613939 - Make sure test and manifest identifiers always use forward slashes

Status: RESOLVED FIXED

(Testing :: General, enhancement, P2)

Description

[Marco Castelluccio [:marco]]

Currently, in ActiveData, we have groups such as dom/base/test/chrome.ini and others such as devtools\client\shared\components\test\browser\browser.ini, this means the same manifest could be considered as two separate manifests on Linux and Windows.

Comment 1

[Geoff Brown [:gbrown]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8e5e013aa81b965d2c7e22216871e6e06fbad5e

Comment 2

[Geoff Brown [:gbrown]]

Besides mochitests (all flavors), a scan of windows 10 debug test logs suggests the only other case requiring attention is marionette tests.

Comment 3

[Geoff Brown [:gbrown]]

Attachment: Bug 1613939 - Normalize path separators in mochitest manifest IDs; r=

Convert back slashes to forward slashes in manifest keys used for the manifests.list
and the suite_start message.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a0b9cc394b0
Normalize path separators in mochitest manifest IDs; r=ahal

Comment 5

[Geoff Brown [:gbrown]]

leave-open for marionette, and possibly TestResolver changes.

Comment 6

[Geoff Brown [:gbrown]]

(In reply to Geoff Brown [:gbrown] from comment #5)

leave-open for marionette

Actually, that will be resolved by bug 1613937.

Comment 7

[Geoff Brown [:gbrown]]

:marco -- Other than mochitest and marionette-test, do you know of any other test suites that need attention? Do you know of an ActiveData query, or similar, that we can use to check?

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9a0b9cc394b0

Comment 9

[Marco Castelluccio [:marco]]

You can use an ActiveData query such as:

{
	"from":"unittest",
	"select":["task.id","run.suite.groups"],
	"where":{"and":[
		{"eq":{"etl.id":0}},
		{"eq":{"repo.changeset.id":"ee582f48caa16183f496f63dfd85eefb288ba4fb"}}
	]},
	"limit":10000,
	"format":"table"
}

Just replacing the changeset with a recent one (possibly a full push, so that all tasks are run) which contains your changes.

Comment 10

[Marco Castelluccio [:marco]]

Also:

{
	"from":"unittest",
	"groupby":["result.group"],
	"where":{"and":[{"eq":{"repo.changeset.id":"813768d074e3accc36dc3313d0bffb658dcc562d"}}]},
	"limit":10000,
	"format":"table"
}

To make sure result.group is also correct (assuming result.group is populated differently than run.suite.groups).

Comment 11

[Geoff Brown [:gbrown]]

Thanks. I think we are in good shape now.