1613953 - doh-rollout local storage migration test times out locally due to add-on not being recognized as privileged

Status: RESOLVED FIXED

(Firefox :: Security, defect, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

I don't know why this doesn't happen in automation, but Shane found a fix and I think we should land it.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1613953 - Install doh-rollout add-on as builtin rather than temporary in local storage migration test. r=mixedpuppy!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2176eab309a8
Install doh-rollout add-on as builtin rather than temporary in local storage migration test. r=mixedpuppy

Comment 3

[Daniel Varga [:dvarga]]

Backed out changeset 2176eab309a8 (Bug 1613953) for causing xpcshell failures at browser/extensions/doh-rollout/test/unit/test_localStorageMigration.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=2176eab309a8e571a522d92aaec5b9fc952b600e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287948411&repo=autoland&lineNumber=2306

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=d846bfa09f1f2012f9b34b5aef1c728fa922159d

[task 2020-02-07T16:47:41.134Z] 16:47:41     INFO -  TEST-START | browser/extensions/doh-rollout/test/unit/test_localStorageMigration.js
[task 2020-02-07T16:47:41.914Z] 16:47:41  WARNING -  TEST-UNEXPECTED-FAIL | browser/extensions/doh-rollout/test/unit/test_localStorageMigration.js | xpcshell return code: 0
[task 2020-02-07T16:47:41.915Z] 16:47:41     INFO -  TEST-INFO took 777ms
[task 2020-02-07T16:47:41.915Z] 16:47:41     INFO -  >>>>>>>
[task 2020-02-07T16:47:41.915Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.916Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.916Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.916Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.916Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.916Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.916Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.916Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.916Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.917Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.917Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.917Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.917Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/workspace/build/src/toolkit/crashreporter/nsExceptionHandler.cpp, line 2943
[task 2020-02-07T16:47:41.917Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.917Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.918Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.918Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.918Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.919Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.919Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.919Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.920Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.920Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.921Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167
[task 2020-02-07T16:47:41.921Z] 16:47:41     INFO -  PID 18890 | [18890, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 167

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Shane, do you have any idea what's going on here? Seems like between installing as builtin and installing as temporary, the former works locally and breaks automation, and the latter works on automation but is busted locally.

I don't have cycles to look at this until Wednesday, so I thought I'd needinfo? here in case you do. If not, I'll take a look later in the week. Thanks!

Comment 5

[Shane Caraveo (:mixedpuppy)]

This week is a little crazy. I'll try to find some time to look at it (leaving ni for myself)

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nhnt11, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

The DoH heuristics code was ported into a JS component, and several mechanics reworked. The tests live in a new directory and have all been re-enabled, and I'd like to track any new intermittents in new bugs. Closing all open intermittent test failure bugs associated with the old extension.