AudioBuffer::CopyToChannel does non-spec length check
Categories
(Core :: Web Audio, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: koalab1999, NeedInfo)
References
(Depends on 1 open bug)
Details
Attachments
(2 files)
AudioBuffer::CopyToChannel checks that aStartInChannel <= Length() (or more precisely throws if aStartInChannel > Length()). I don't see this check in the spec.
There's also a non-spec detached-buffer check.
|
||
Comment 1•4 years ago
|
||
Also removed those in CopyFromChannel and changed parameters' name to fit the spec.
|
||
Updated•4 years ago
|
Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7c315d9e2030 Removed non-spec exception throwing on CopyToChannel. r=padenot,webidl,smaug https://hg.mozilla.org/integration/autoland/rev/2bd694126445 Updated mochitest. r=padenot
|
||
Comment 5•4 years ago
|
||
Backed out 2 changesets (bug 1614009) for build bustage at dom/media/webaudio/AudioBuffer.cpp
Backout: https://hg.mozilla.org/integration/autoland/rev/f7817f1be22afc6d149471f646dbcc69d49bd1cb
Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2bd694126445facf9dcd6eed0656189c698e3d4a
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311655487&repo=autoland&lineNumber=13823
|
|
||
Updated•4 years ago
|
Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c3832cde86d2 Removed non-spec exception throwing on CopyToChannel. r=padenot,webidl,smaug https://hg.mozilla.org/integration/autoland/rev/e05106d5d786 Updated mochitest. r=padenot
|
||
Comment 7•4 years ago
|
||
Backed out 2 changesets (bug 1614009) for webaudio related bustage.
Backout link: https://hg.mozilla.org/integration/autoland/rev/aee92a0bbc2a4369ac2339f31d08dc52b2147114
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314569863&repo=autoland&lineNumber=15954
[task 2020-09-01T14:34:09.790Z] 14:34:09 INFO - In file included from Unified_cpp_dom_media_webaudio0.cpp:38:
[task 2020-09-01T14:34:09.790Z] 14:34:09 INFO - In file included from /builds/worker/checkouts/gecko/dom/media/webaudio/AudioContext.cpp:51:
[task 2020-09-01T14:34:09.790Z] 14:34:09 INFO - In file included from /builds/worker/checkouts/gecko/dom/media/AudioStream.h:18:
[task 2020-09-01T14:34:09.790Z] 14:34:09 INFO - /builds/worker/checkouts/gecko/dom/media/WavDumper.h(43,13): warning: Usage of ASCII file functions (here fopen) is forbidden on Windows.
[task 2020-09-01T14:34:09.790Z] 14:34:09 INFO - mFile = fopen(buf, "wb");
[task 2020-09-01T14:34:09.790Z] 14:34:09 INFO - ^
[task 2020-09-01T14:34:09.790Z] 14:34:09 INFO - /builds/worker/checkouts/gecko/dom/media/WavDumper.h(43,13): note: On Windows executed functions: fopen, fopen_s, open, _open, _sopen, _sopen_s, OpenFile, CreateFileA should never be used due to lossy conversion from UTF8 to ANSI.
[task 2020-09-01T14:34:09.790Z] 14:34:09 INFO - 1 warning and 1 error generated.
[task 2020-09-01T14:34:09.790Z] 14:34:09 ERROR - make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:725: Unified_cpp_dom_media_webaudio0.obj] Error 1
[task 2020-09-01T14:34:09.790Z] 14:34:09 INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/media/webaudio'
[task 2020-09-01T14:34:09.790Z] 14:34:09 INFO - make[4]: *** Waiting for unfinished jobs....
Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/606cd15f3bf4 Removed non-spec exception throwing on CopyToChannel. r=padenot,webidl,smaug
Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e5f5e1e1d45 Updated mochitest. r=padenot
|
||
Comment 10•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/606cd15f3bf4
https://hg.mozilla.org/mozilla-central/rev/5e5f5e1e1d45
Description
•