Closed Bug 1614085 Opened 4 years ago Closed 4 years ago

Enhanced Tracking Protection breaks Facebook domain internalfb.com

Categories

(Core :: Privacy: Anti-Tracking, defect, P1)

Product:
Core
Component:
Privacy: Anti-Tracking
Version:
72 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: sites+mozilla, Assigned: englehardt)

References

(Blocks 2 open bugs,
URL
)

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

internalfb.com is a domain we use internally at Facebook. The tracking protection breaks all CSS and JS on this site. To repro, open https://www.internalfb.com/ with enhanced tracking protection enabled.

Related to #1590944

Actual results:

CSS and JS don't load, errors like this are thrown:

The resource at “https://s-static.intern.facebook.com/rsrc.php/v3/yH/l/0,cross/AKB-YRbNHMJ.css?_nc_x=Ij3Wp8lg5Kz” was blocked because content blocking is enabled

Expected results:

CSS and JS should load

Blocks: tp-breakage, etp-breakage
See Also: → 1590944

I submitted a PR to add internalfb.com to the list of Facebook properties in the Disconnect services list, however I'm not sure if any other changes are needed to fix this: https://github.com/disconnectme/disconnect-tracking-protection/pull/127

URL: https://www.internalfb.com
Has STR: --- → yes
Component: Untriaged → Privacy: Anti-Tracking
Product: Firefox → Core
See Also: → https://github.com/disconnectme/disconnect-tracking-protection/pull/127
Summary: Enhanced Tracking Protection breaks internalfb.com → Enhanced Tracking Protection breaks Facebook domain internalfb.com

(In reply to Daniel Lo Nigro (daniel15) from comment #1)

I submitted a PR to add internalfb.com to the list of Facebook properties in the Disconnect services list, however I'm not sure if any other changes are needed to fix this: https://github.com/disconnectme/disconnect-tracking-protection/pull/127

Thanks, that should probably be sufficient to fix this.

(In reply to :ehsan akhgari from comment #2)

(In reply to Daniel Lo Nigro (daniel15) from comment #1)

I submitted a PR to add internalfb.com to the list of Facebook properties in the Disconnect services list, however I'm not sure if any other changes are needed to fix this: https://github.com/disconnectme/disconnect-tracking-protection/pull/127

Thanks, that should probably be sufficient to fix this.

Thanks for the confirmation! Is there someone I should ping to review the PR? It's been open for a while with no comments.

Assignee: nobody → senglehardt
Priority: -- → P1

I pinged Disconnect on this and will keep this bug updated.

This was merged in https://github.com/mozilla-services/shavar-prod-lists/pull/128 to all channels.

Thanks again for the report Daniel. Please let us know if you still experience breakage.

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.