161414 - Some Properties windows in Bookmark Manager not properly sized

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Jason Bassford]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.1b) Gecko/20020806
BuildID:    2002080614

The patch checked in for bug 83298, while appropriately changing the descriptive
text for tab group folders in Bookmark Manager, has resulted in the bottom
portion of the OK and Cancel buttons being cut off.

Reproducible: Always
Steps to Reproduce:
1. Open Bookmark Manager.
2. Highlight a tab group folder.
3. Bring up the Properties dialogue.

Actual Results:  The window has insufficient vertical height, cutting off the OK
and Cancel buttons.

Expected Results:  The window should be sized properly.

CCing Pierre Chanial from bug 83298.

Comment 1

[Jason Bassford]

Come to think of it, there's something even more wrong.   Group folders have OK
and Cancel buttons (for when text is changed) but both regular folders and
bookmarks are missing these controls.

Comment 2

[Jason Bassford]

Updating Summary as per comment 1.

Old summary: Properties window for group folders in Bookmark Manager not
properly sized.

Comment 3

[Pierre Chanial]

Mea Culpa. Note that I never noticed it on a fresh profile.
I will investigate it.

Comment 4

[Malcolm Scott]

Reporter: is this a duplicate of bug 162828 (or vice versa)? See screenshots on
that bug.

Comment 5

[Jason Bassford]

I don't know.  It's not clear to me if there actually *IS* no "OK" button in the
code, or if it's simply scrolled off of the bottom of the available vertical space.

If both bugs are a result of the same problem (which may be the fix for bug
83298 as per commment 0) then the other bug should be a dupe of this one.  (It
was reported first, and I actually did change the Summary text at one point to
reflect both symptoms, but it was changed back again by Pierre Chanial.)

Pierre: Can you comment on this?

Comment 6

[Jason Bassford]

Can we get some update on this?  It's still not clear if bug 162828 is a dupe of
this or not.

Comment 7

[Dimitrios]

Let's clear up the issue a bit. 
- Renaming/Properties dialogues for Tab Groups don't work (as this bug says.
- Rename/Properties dialogues for simple bookmarks don't work (modern theme, see
bug 167461). Bug 161970 is a duplicate. 
- Rename/Properties dialogues for folders work as expected.

Updating summary to "Some Properties windows in Bookmark Manager not properly
sized" to make it more generic.

Comment 8

[Dimitrios]

*** Bug 167461 has been marked as a duplicate of this bug. ***

Comment 9

[Dimitrios]

*** Bug 161970 has been marked as a duplicate of this bug. ***

Comment 10

[Dimitrios]

*** Bug 162828 has been marked as a duplicate of this bug. ***

Comment 11

[Pierre Chanial]

Neil, could you have a look to this bug? I can not reproduce it on linux.
Reporters, this bug does not happen with a fresh new profile, right?
I thought I removed a SizeToContent() call in bm-props.js but I didn't.

Comment 12

[Jason Bassford]

> Reporters, this bug does not happen with a fresh new profile, right?

Wrong.  2002090608 trunk / XP - created a new profile using Modern theme and the
OK and Cancel buttons were still missing.

Comment 13

[Dimitrios]

Surely a new profile doesn't cure, as Jason said. For me, modern theme is the
sole prerequisite in order to reproduce the bug.

Comment 14

[Pierre Chanial]

Neil just told me he can't reproduce this bug on Win95.
So far win NT/2000/XP and Mac 9 are affected.
I may I have found the offender: in bm-props.xul, I removed the description
textNode and instead of that, I insert it in the startup function.

In the problematic platforms, it seems like SizeToContent() has no effect, maybe
because the dialog widget can not be resized, unlike in linux.
So a solution would be to inline the description insertion before the dialog get
opened as it is similarly done in commonDialog.xul

Comment 15

[Pierre Chanial]

Attachment: Patch v1.0

Could anybody try to see if this patch fixes the problem?

Comment 16

[timeless]

Comment on attachment 98444 [details] [diff] [review]
Patch v1.0

this works nicely on macos :)

Comment 17

[Brian Ryner (not reading)]

Comment on attachment 98444 [details] [diff] [review]
Patch v1.0

sr=bryner

Comment 18

[Pierre Chanial]

checked in. Could someone verify it on windows, please?

Comment 19

[Sven Grull]

wfm Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2a) Gecko/20020911

Comment 20

[Jason Bassford]

WFM too - 2002091108 trunk / XP.

-> Verifying.

Comment 21

[Jean-Pierre Melkonian]

WFM now on MACOS 9.1 Build 2002091108

Comment 22

[Jason Bassford]

*** Bug 168641 has been marked as a duplicate of this bug. ***

Comment 23

[Chris Lyon]

*** Bug 171380 has been marked as a duplicate of this bug. ***

Comment 24

[Mats Palmgren (inactive)]

*** Bug 171535 has been marked as a duplicate of this bug. ***

Comment 25

[Torben]

*** Bug 174580 has been marked as a duplicate of this bug. ***