Closed Bug 1614166 Opened 4 years ago Closed 4 years ago

Fix colorpickers and filefields in preferences

Categories

(SeaMonkey :: UI Design, defect)

Product:
SeaMonkey
Component:
UI Design
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.53 fixed, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.72
Tracking Flags:
Tracking Status
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.1)

Attachments

(2 files, 4 obsolete files)

Fix css in preferences for 2.53.x v1.2
1.07 KB, patch
frg
: review+
frg
: approval-comm-release+
Details | Diff | Splinter Review
Fix css in preferences for 2.57 v1.2
974 bytes, patch
frg
: review+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

At the moment colorpickers show only a thin strip of colour on the buttons and filefield content boxes grow outside of their surrounding filefield.

Attached patch Fix css in preferences (obsolete) — — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: some preference panels look wrong
Testing completed (on m-c, etc.): 2.53 on linux
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Only tested on linux, might need adjustments on mac and windows.

Attachment #9125306 - Flags: review?(frgrahl)
Attachment #9125306 - Flags: approval-comm-release?
Attachment #9125306 - Flags: approval-comm-esr60?
Attachment #9125306 - Flags: approval-comm-release?

Equivalent patch for 2.53.x

Attachment #9125354 - Flags: review?(frgrahl)
Attachment #9125354 - Flags: approval-comm-release?

colorpicker changes are only needed on linux, so split by platform

Attachment #9125354 - Attachment is obsolete: true
Attachment #9125354 - Flags: review?(frgrahl)
Attachment #9125354 - Flags: approval-comm-release?
Attachment #9125495 - Flags: review?(frgrahl)
Attachment #9125495 - Flags: approval-comm-release?

colorpicker changes are only needed on linux, so only do those on that platform

Attachment #9125306 - Attachment is obsolete: true
Attachment #9125306 - Flags: review?(frgrahl)
Attachment #9125306 - Flags: approval-comm-esr60?
Attachment #9125496 - Flags: review?(frgrahl)
Attachment #9125496 - Flags: approval-comm-esr60?

So it seems it is linux only. Also happens outside of prefs so moving to communicator.css

Attachment #9125495 - Attachment is obsolete: true
Attachment #9125495 - Flags: review?(frgrahl)
Attachment #9125495 - Flags: approval-comm-release?
Attachment #9125526 - Flags: review?(frgrahl)
Attachment #9125526 - Flags: approval-comm-release?

So it seems it is linux only. Also happens outside of prefs so moving to communicator.css

Attachment #9125496 - Attachment is obsolete: true
Attachment #9125496 - Flags: review?(frgrahl)
Attachment #9125496 - Flags: approval-comm-esr60?
Attachment #9125527 - Flags: review?(frgrahl)
Attachment #9125527 - Flags: approval-comm-esr60?
Comment on attachment 9125526 [details] [diff] [review]
Fix css in preferences for 2.53.x v1.2

LGTM
Attachment #9125526 - Flags: review?(frgrahl)
Attachment #9125526 - Flags: review+
Attachment #9125526 - Flags: approval-comm-release?
Attachment #9125526 - Flags: approval-comm-release+
Comment on attachment 9125527 [details] [diff] [review]
Fix css in preferences for 2.57 v1.2

LGTM
Attachment #9125527 - Flags: review?(frgrahl)
Attachment #9125527 - Flags: review+
Attachment #9125527 - Flags: approval-comm-esr60?
Attachment #9125527 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/0d93f5cf6d49
Fix colorpickers and filefields in preferences. r=frg

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
status-seamonkey2.57esr: affected → fixed
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: